Closed
Bug 765498
Opened 13 years ago
Closed 13 years ago
Device Storage - Gaia - ensure /sdcard is backed by a file system
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: dougt, Assigned: dougt)
References
Details
Attachments
(1 file)
|
2.04 KB,
patch
|
dhylands
:
review+
|
Details | Diff | Splinter Review |
follow up from bug 765444. Specifically https://bugzilla.mozilla.org/show_bug.cgi?id=765444#c8
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #643096 -
Flags: review?(dhylands)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 643096 [details] [diff] [review]
patch v.1
Review of attachment 643096 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Although I think that you also need to add an Observer to detect when the volume becomes unmounted, and is no longer available for use (unless SetRootFileForType is called on every file access).
Attachment #643096 -
Flags: review?(dhylands) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 643096 [details] [diff] [review]
patch v.1
I will land the observer stuff in a different bug.
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•