Last Comment Bug 765498 - Device Storage - Gaia - ensure /sdcard is backed by a file system
: Device Storage - Gaia - ensure /sdcard is backed by a file system
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: Doug Turner (:dougt)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on: 764228 765444
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-16 10:00 PDT by Doug Turner (:dougt)
Modified: 2012-07-19 07:34 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v.1 (2.04 KB, patch)
2012-07-17 12:49 PDT, Doug Turner (:dougt)
dhylands: review+
Details | Diff | Splinter Review

Description Doug Turner (:dougt) 2012-06-16 10:00:24 PDT
follow up from bug 765444.  Specifically https://bugzilla.mozilla.org/show_bug.cgi?id=765444#c8
Comment 1 Doug Turner (:dougt) 2012-07-17 12:49:44 PDT
Created attachment 643096 [details] [diff] [review]
patch v.1
Comment 2 Dave Hylands [:dhylands] 2012-07-18 07:51:26 PDT
Comment on attachment 643096 [details] [diff] [review]
patch v.1

Review of attachment 643096 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Although I think that you also need to add an Observer to detect when the volume becomes unmounted, and is no longer available for use (unless SetRootFileForType is called on every file access).
Comment 3 Doug Turner (:dougt) 2012-07-18 11:26:12 PDT
Comment on attachment 643096 [details] [diff] [review]
patch v.1

I will land the observer stuff in a different bug.
Comment 5 Ed Morley [:emorley] 2012-07-19 07:34:15 PDT
https://hg.mozilla.org/mozilla-central/rev/2373e19febf9

Note You need to log in before you can comment on or make changes to this bug.