Closed
Bug 765588
Opened 12 years ago
Closed 12 years ago
Named properties on CSSFontFaceStyleDecl broken
Categories
(Core :: DOM: CSS Object Model, defect)
Core
DOM: CSS Object Model
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: Ms2ger, Assigned: bzbarsky)
References
()
Details
Attachments
(1 file)
3.02 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
See <http://software.hixie.ch/utilities/js/live-dom-viewer/saved/1588>. We throw 'Exception... "Could not convert JavaScript argument" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"...', because the xpc_qsUnwrapThis to nsICSSDeclaration in nsIDOMCSS2Properties_Get fails. I guess we'll need to have nsCSSFontFaceStyleDecl implement nsICSSDeclaration as well as nsIDOMCSSDeclaration, and audit all other implementations.
Assignee | ||
Comment 1•12 years ago
|
||
This is not a CSSStyleDeclaration; the actual set of supported properties needs to be different. So it's not at all clear to me that the named property thing should work at all.
Component: DOM → DOM: CSS Object Model
QA Contact: general → style-system
Reporter | ||
Comment 2•12 years ago
|
||
That's not what the spec says... <http://dev.w3.org/csswg/cssom/#cssfontfacerule>
Assignee | ||
Comment 3•12 years ago
|
||
Well, the spec is totally broken. What, exactly, should .style.azimuth return on a font-face rule? What should happen when you set .style.display on such a rule? Maybe this section of the spec was written before CSS2Properties was merged into CSSStyleDeclaration? Or maybe like most of CSSOM it's just broken and unmaintained? Do you want to raise the spec issue, or should I? ;)
Updated•12 years ago
|
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #637268 -
Flags: review?(dbaron)
Assignee | ||
Comment 5•12 years ago
|
||
Note that in bug 753517 I plan to disappear these props from here altogether (which will be somewhat different than them throwing). Hence the lack of a test for them working, though I could certainly add a test for the getter not throwing.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → bzbarsky
Whiteboard: [need review]
Comment on attachment 637268 [details] [diff] [review] Make CSSFontFaceStyleDecl an nsICSSDeclaration. r=dbaron
Attachment #637268 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/466ee6779566
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla17
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/466ee6779566
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•