Closed Bug 765590 Opened 7 years ago Closed 7 years ago

CSSNameSpaceRule.type should be 10, not 0

Categories

(Core :: DOM: CSS Object Model, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: Ms2ger, Assigned: jhk)

References

()

Details

(Keywords: dev-doc-complete, Whiteboard: [good first bug][mentor=Ms2ger][lang=c++])

Attachments

(1 file, 1 obsolete file)

Yeah, I don't think there was a value assigned at the time we implemented this.

Are you interested in posting a patch?
We could probably make this a "good first bug" too, although I am not sure this is really a good one...
To fix this bug, a new constant NAMESPACE_RULE = 10; should be added to <http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/css/nsIDOMCSSRule.idl>, and the implementation at <http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSRules.cpp#1197> should be updated to use it instead of the UNKNOWN_RULE it has now.
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++]
Attached patch Patch(v1) (obsolete) — Splinter Review
Attachment #635234 - Flags: feedback?(Ms2ger)
Comment on attachment 635234 [details] [diff] [review]
Patch(v1)

Review of attachment 635234 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, code-wise; a test would be good, though.
Attachment #635234 - Flags: feedback?(Ms2ger) → feedback+
Attached patch Patch(v2)Splinter Review
Patch+test. I tested it locally and it doesn't break any other tests.
Attachment #635234 - Attachment is obsolete: true
Attachment #635276 - Flags: review?(Ms2ger)
Comment on attachment 635276 [details] [diff] [review]
Patch(v2)

Review of attachment 635276 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #635276 - Flags: review?(dbaron)
Attachment #635276 - Flags: review?(Ms2ger)
Attachment #635276 - Flags: feedback+
Comment on attachment 635276 [details] [diff] [review]
Patch(v2)

r=dbaron
Attachment #635276 - Flags: review?(dbaron) → review+
Assignee: nobody → jigneshhk1992
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0f3f06fbe11d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Keywords: dev-doc-needed
I've added a line in :
https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers

Updated: https://developer.mozilla.org/en-US/docs/DOM/CSSRule which was quite outdated.

Created: https://developer.mozilla.org/en-US/docs/DOM/CSSNamespaceRule as it didn't existed at all!

Note that I still to add a link from the doc for @namespace to the CSSOM interface, but as this at-rule is not yet documented, I'll wait a bit. (Anyway I have to make sure that every combination of at-rule/CSSOM interface are correctly linked and documented.
You need to log in before you can comment on or make changes to this bug.