Note: There are a few cases of duplicates in user autocompletion which are being worked on.

CSSNameSpaceRule.type should be 10, not 0

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: CSS Object Model
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: jhk)

Tracking

({dev-doc-complete})

Trunk
mozilla16
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=Ms2ger][lang=c++], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Tested by <http://hg.csswg.org/test/raw-file/66831c5c0299/contributors/ttwf/divya/submitted/index-003.html>.
Yeah, I don't think there was a value assigned at the time we implemented this.

Are you interested in posting a patch?
We could probably make this a "good first bug" too, although I am not sure this is really a good one...
(Reporter)

Comment 3

5 years ago
To fix this bug, a new constant NAMESPACE_RULE = 10; should be added to <http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/css/nsIDOMCSSRule.idl>, and the implementation at <http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSRules.cpp#1197> should be updated to use it instead of the UNKNOWN_RULE it has now.
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++]
and also see http://wiki.csswg.org/spec/cssom-constants
(Assignee)

Comment 5

5 years ago
Created attachment 635234 [details] [diff] [review]
Patch(v1)
Attachment #635234 - Flags: feedback?(Ms2ger)
(Reporter)

Comment 6

5 years ago
Comment on attachment 635234 [details] [diff] [review]
Patch(v1)

Review of attachment 635234 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, code-wise; a test would be good, though.
Attachment #635234 - Flags: feedback?(Ms2ger) → feedback+
(Assignee)

Comment 7

5 years ago
Created attachment 635276 [details] [diff] [review]
Patch(v2)

Patch+test. I tested it locally and it doesn't break any other tests.
Attachment #635234 - Attachment is obsolete: true
Attachment #635276 - Flags: review?(Ms2ger)
(Reporter)

Comment 8

5 years ago
Comment on attachment 635276 [details] [diff] [review]
Patch(v2)

Review of attachment 635276 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #635276 - Flags: review?(dbaron)
Attachment #635276 - Flags: review?(Ms2ger)
Attachment #635276 - Flags: feedback+
Comment on attachment 635276 [details] [diff] [review]
Patch(v2)

r=dbaron
Attachment #635276 - Flags: review?(dbaron) → review+
(Reporter)

Updated

5 years ago
Assignee: nobody → jigneshhk1992
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f3f06fbe11d
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/0f3f06fbe11d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Keywords: dev-doc-needed
I've added a line in :
https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers

Updated: https://developer.mozilla.org/en-US/docs/DOM/CSSRule which was quite outdated.

Created: https://developer.mozilla.org/en-US/docs/DOM/CSSNamespaceRule as it didn't existed at all!

Note that I still to add a link from the doc for @namespace to the CSSOM interface, but as this at-rule is not yet documented, I'll wait a bit. (Anyway I have to make sure that every combination of at-rule/CSSOM interface are correctly linked and documented.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.