765590 - CSSNameSpaceRule.type should be 10, not 0

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Tested by <http://hg.csswg.org/test/raw-file/66831c5c0299/contributors/ttwf/divya/submitted/index-003.html>.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, I don't think there was a value assigned at the time we implemented this.

Are you interested in posting a patch?

Comment 2

[Kang-Hao (Kenny) Lu [:kennyluck]]

We could probably make this a "good first bug" too, although I am not sure this is really a good one...

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

To fix this bug, a new constant NAMESPACE_RULE = 10; should be added to <http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/css/nsIDOMCSSRule.idl>, and the implementation at <http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSRules.cpp#1197> should be updated to use it instead of the UNKNOWN_RULE it has now.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

and also see http://wiki.csswg.org/spec/cssom-constants

Comment 5

[Jignesh Kakadiya [:jhk]]

Attachment: Patch(v1)

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 635234 [details] [diff] [review]
Patch(v1)

Review of attachment 635234 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, code-wise; a test would be good, though.

Comment 7

[Jignesh Kakadiya [:jhk]]

Attachment: Patch(v2)

Patch+test. I tested it locally and it doesn't break any other tests.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 635276 [details] [diff] [review]
Patch(v2)

Review of attachment 635276 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 635276 [details] [diff] [review]
Patch(v2)

r=dbaron

Comment 10

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f3f06fbe11d

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0f3f06fbe11d

Comment 12

[Jean-Yves Perrier [:teoli]]

I've added a line in :
https://developer.mozilla.org/en-US/docs/Firefox_16_for_developers

Updated: https://developer.mozilla.org/en-US/docs/DOM/CSSRule which was quite outdated.

Created: https://developer.mozilla.org/en-US/docs/DOM/CSSNamespaceRule as it didn't existed at all!

Note that I still to add a link from the doc for @namespace to the CSSOM interface, but as this at-rule is not yet documented, I'll wait a bit. (Anyway I have to make sure that every combination of at-rule/CSSOM interface are correctly linked and documented.