765596 - Error in macro InstallOnInitCommon on macroline 152

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Comment 1

[Philip Chee]

Usage: StrCpy $(user_var: output) str [maxlen] [startoffset]
Error in macro InstallOnInitCommon on macroline 152
Error in script "installer.nsi" on line 87 -- aborting creation process

http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh?mark=4864-4867#4864

4864             ReadINIStr $R8 $R7 "Install" "MaintenanceService"
4865             ${If} $R8 == "false"
4866               StrCpy $InstallMaintenanceService "0"
4867             ${EndIf}

Bug 741174 - Add a silent install option for Mozilla Maintenance Service

http://hg.mozilla.org/mozilla-central/rev/ea52f4eb380c
author	Brian R. Bondy <[e-mail]>
Fri Jun 15 08:08:31 2012 -0400 (at Fri Jun 15 08:08:31 2012 -0400)

TB Bug 758326 - Port bug 481815 - Provide a Windows service to update applications without asking Administrator password.
https://hg.mozilla.org/comm-central/rev/981ac3d7e714#l13.36

Adding this one line from the Thunderbird patch fixes the problem locally.

Comment 2

[Philip Chee]

Attachment: Patch v1.0 minimal bustage fix.

Pushed:
http://hg.mozilla.org/comm-central/rev/954f7f221df4

Leaving open for any follow-up fixes.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 633914 [details] [diff] [review]
Patch v1.0 minimal bustage fix.

This should do things just fine :-)

Comment 4

[Philip Chee]

I guess we can close it now.