Error in macro InstallOnInitCommon on macroline 152

RESOLVED FIXED

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: philip.chee, Assigned: philip.chee)

Tracking

Trunk
x86
Windows 7
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

7 years ago
No description provided.
Assignee

Comment 1

7 years ago
Usage: StrCpy $(user_var: output) str [maxlen] [startoffset]
Error in macro InstallOnInitCommon on macroline 152
Error in script "installer.nsi" on line 87 -- aborting creation process

http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh?mark=4864-4867#4864

4864             ReadINIStr $R8 $R7 "Install" "MaintenanceService"
4865             ${If} $R8 == "false"
4866               StrCpy $InstallMaintenanceService "0"
4867             ${EndIf}

Bug 741174 - Add a silent install option for Mozilla Maintenance Service

http://hg.mozilla.org/mozilla-central/rev/ea52f4eb380c
author	Brian R. Bondy <netzen@gmail.com>
Fri Jun 15 08:08:31 2012 -0400 (at Fri Jun 15 08:08:31 2012 -0400)

TB Bug 758326 - Port bug 481815 - Provide a Windows service to update applications without asking Administrator password.
https://hg.mozilla.org/comm-central/rev/981ac3d7e714#l13.36

Adding this one line from the Thunderbird patch fixes the problem locally.
Blocks: 741174
Assignee

Comment 2

7 years ago
Pushed:
http://hg.mozilla.org/comm-central/rev/954f7f221df4

Leaving open for any follow-up fixes.
Attachment #633914 - Flags: review?(bugzilla)
Attachment #633914 - Flags: review?(bugspam.Callek)
Comment on attachment 633914 [details] [diff] [review]
Patch v1.0 minimal bustage fix.

This should do things just fine :-)
Attachment #633914 - Attachment is patch: true
Attachment #633914 - Flags: review?(bugzilla)
Attachment #633914 - Flags: review?(bugspam.Callek)
Attachment #633914 - Flags: review+
Assignee: installer → philip.chee
Status: NEW → ASSIGNED
Assignee

Comment 4

7 years ago
I guess we can close it now.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.