Distinguish new bug filings from updates to existing ones

RESOLVED FIXED

Status

()

enhancement
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: reed, Assigned: reed)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

One thing that bothers me with SecureMail is that new bugs are not distinguished any differently than existing ones. This is a change from non-securemail, and considering the headers are plaintext and give this information (X-Bugzilla-Type: new), it would be nice to have this simple distinction back.

A few possible options:
* Re-add "New: " in front of the (Secure bug xxxx updated) part
* Change "(Secure bug xxxx updated) to "(Secure bug xxxx filed)" or submitted or something
Posted patch patch - v1 (untested) (obsolete) — Splinter Review
Here's a patch that implements the first suggestion. I don't care either way between the two possible suggestions (or something else).
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #633942 - Flags: review?(glob)
Comment on attachment 633942 [details] [diff] [review]
patch - v1 (untested)

i'm happy with fixing it this way (i agree the removing the prefix is a bug), however you need to honour the bugmail_new_prefix user preference (if it exists in that version of bugzilla).
Attachment #633942 - Flags: review?(glob) → review-
See if you like how I did it here... I could just make $add_new the actual string to add rather than the boolean, but I kinda like separating them...
Attachment #633942 - Attachment is obsolete: true
Attachment #634285 - Flags: review?(glob)
Comment on attachment 634285 [details] [diff] [review]
patch - v2 (untested)

this works, but results in:

  [Bug 731661] New: (Secure bug 731661 updated)

something about the subject stating both "new" and "updated" doesn't sit right with me.  but i'm sure if we did the right thing (drop "updated" from new bug subjects), gmail will fail to thread :(

so, ugly as it is, r=glob

don't forget to commit to 4.0, 4.2 and extensions/SecureMail :)
Attachment #634285 - Flags: review?(glob) → review+
Committing to: bzr+ssh://bzr.mozilla.org/bmo/4.0/
modified extensions/SecureMail/Extension.pm
Committed revision 8216.

Committing to: bzr+ssh://bzr.mozilla.org/bmo/4.2/
modified extensions/SecureMail/Extension.pm
Committed revision 8208.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/extensions/securemail/4.0/
modified Extension.pm
Committed revision 24.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.