765640 - Distinguish new bug filings from updates to existing ones

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, enhancement)

Description

[Reed Loden [:reed]]

One thing that bothers me with SecureMail is that new bugs are not distinguished any differently than existing ones. This is a change from non-securemail, and considering the headers are plaintext and give this information (X-Bugzilla-Type: new), it would be nice to have this simple distinction back.

A few possible options:
* Re-add "New: " in front of the (Secure bug xxxx updated) part
* Change "(Secure bug xxxx updated) to "(Secure bug xxxx filed)" or submitted or something

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1 (untested)

Here's a patch that implements the first suggestion. I don't care either way between the two possible suggestions (or something else).

Comment 2

[:glob ✱]

Comment on attachment 633942 [details] [diff] [review]
patch - v1 (untested)

i'm happy with fixing it this way (i agree the removing the prefix is a bug), however you need to honour the bugmail_new_prefix user preference (if it exists in that version of bugzilla).

Comment 3

[Reed Loden [:reed]]

Attachment: patch - v2 (untested)

See if you like how I did it here... I could just make $add_new the actual string to add rather than the boolean, but I kinda like separating them...

Comment 4

[:glob ✱]

Comment on attachment 634285 [details] [diff] [review]
patch - v2 (untested)

this works, but results in:

  [Bug 731661] New: (Secure bug 731661 updated)

something about the subject stating both "new" and "updated" doesn't sit right with me.  but i'm sure if we did the right thing (drop "updated" from new bug subjects), gmail will fail to thread :(

so, ugly as it is, r=glob

don't forget to commit to 4.0, 4.2 and extensions/SecureMail :)

Comment 5

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bmo/4.0/
modified extensions/SecureMail/Extension.pm
Committed revision 8216.

Committing to: bzr+ssh://bzr.mozilla.org/bmo/4.2/
modified extensions/SecureMail/Extension.pm
Committed revision 8208.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/extensions/securemail/4.0/
modified Extension.pm
Committed revision 24.