765704 - Don't throw when setting XHR.responseType to an invalid value

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The algorithm at <http://dev.w3.org/2006/webapi/WebIDL/#dfn-attribute-setter> explicitly special-cases enums, so that setting an enum attribute to an unrecognized value silently fails, rather than throwing. We broke that.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We have to fix this before release.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

This isn't terribly elegant, but it seems to work, at least.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 634043 [details] [diff] [review]
Patch v1

I don't think you need the invalidEnumValueFatal function.  Just pass "not setter" in CGPerSignatureCall.__init__ ?

r=me.  Please add mochtests for XHR here or something to actually exercise this code?  Also tests for the fact that the method argument throws...

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 634043 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 740069
User impact if declined: scripts can break if they set responseType to something unrecognized
Testing completed (on m-c, etc.): passes try <https://tbpl.mozilla.org/?tree=Try&rev=ac41076a1718>
Risk to taking this patch (and alternatives if risky): small
String or UUID changes made by this patch: none

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Looks like we'll get this into all branches with plenty of time but setting tracking anyway in case there are any followup issues.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 634043 [details] [diff] [review]
Patch v1

low risk fix, test included, and we're still nice and early in the beta cycle - approving.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/9ce5e415d5da

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/238fc377f102
https://hg.mozilla.org/releases/mozilla-beta/rev/567afb848289

Comment 9

[Ioana (away)]

The test that verified this fix (test_enums.html) is passing on all the OSs:
https://tbpl.mozilla.org/php/getParsedLog.php?id=14175380&full=1&branch=mozilla-beta
https://tbpl.mozilla.org/php/getParsedLog.php?id=14174727&full=1&branch=mozilla-beta
https://tbpl.mozilla.org/php/getParsedLog.php?id=14178339&full=1&branch=mozilla-beta
https://tbpl.mozilla.org/php/getParsedLog.php?id=14178942&full=1&branch=mozilla-beta