The default bug view has changed. See this FAQ.

Don't emit singleton array initializers for empty arrays

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 634035 [details] [diff] [review]
Patch

Kraken crypto-aes/crypto-ccm have a bunch of arrays like [[], [], [], []]. The inner/empty arrays have "unknown properties" because fixArrayType cannot easily determine their type.

This is at least a 10% Kraken crypto-aes/crypto-ccm IonMonkey win since it avoids some GETELEM/SETELEM IC's. JM+TI win is smaller.
Attachment #634035 - Flags: review?(bhackett1024)
Attachment #634035 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7d593a7e561
Target Milestone: --- → mozilla16
Whiteboard: [js:t]
https://hg.mozilla.org/mozilla-central/rev/e7d593a7e561
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.