76587 - huge context menu in ftp of file listing when no content in focus

Status: VERIFIED FIXED

Description

[sairuh (rarely reading bugmail)]

this is reminiscent of bug 74019 --but i'm not sure if it's the same exact
thing, hence this bug. :)

1. go to an ftp site or directory view listing --best to go to one where the
listing does *not* take up the entire viewer region [ie, no scrolling needed].
2. make sure that no file or folder is selected or highlighted.
3. bring up context menu

result: context menu with extra helpings! ;) will attach screenshot soon.

Comment 1

[sairuh (rarely reading bugmail)]

Created attachment 31367 [details]
context menu w/too many items

Comment 2

[Bradley Baetz]

I don't see this. Are you getting js errors to the console when this happens? If
so, then this is a symptom of bug 74539 - when the JS is invalid, all the
possible entries in the context menu show for some reason. (That may be the
reason for bug 74019)

If you can reliably reproduce this, please add comments to 74539 :)

Comment 3

[sairuh (rarely reading bugmail)]

yep, i can reliably repro this bug --and i do get js errors:

JavaScript error: 
chrome://communicator/content/nsContextMenu.js line 277: root.getAttribute is
not a function

JavaScript error: 
chrome://cookie/content/cookieContextOverlay.xul line 94: contextMenu has no
properties

JavaScript error: 
 line 0: contextMenu has no properties

JavaScript error: 
chrome://communicator/content/directory/directory.js line 228:
tree.database.RemoveDatasource is not a function

will also add to bug 74539 --however, let me know if i should dup this one in
favor or 74539. thx!

Comment 4

[Bradley Baetz]

*** Bug 77022 has been marked as a duplicate of this bug. ***

Comment 5

[Bradley Baetz]

I'll steal this from blake, and attach a patch.

Comment 6

[Bradley Baetz]

Created attachment 31726 [details] [diff] [review]
patch

Comment 7

[Bradley Baetz]

URL is no longer an attribute on the URL element. So the loop ends up in the
XULDocument, which doesn't have a getAttribute method, and so we get a js error,
which causes the context menu to include all items. This is possibly related to
some of my directory viewer changes, but may not be.

blake, can I get an r=?

Comment 8

[Stephen P. Morse]

r=morse

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

sr=ben since it's just code movement, but you know this is going to break if 
the directory viewer changes to outliner... 

Comment 10

[Bradley Baetz]

Yeah - this entire block (which is only entered if we are an instanceof a
directory viewer) will. There are a couple of other places as well in the code
that assume the directory viewer is a tree IIRC.

Comment 11

[Bradley Baetz]

Fix checked in.

Note to QA - to verify this, you'll have to turn off the html ftp directory
listing (which is now on by default), or use a file:/// url.

Comment 12

[sairuh (rarely reading bugmail)]

vrfy fixed using opt comm bits:

winnt - 2001.05.17.10
linux and mac - 2001.05.17.08