765872 - faulty use of the section element

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect, P4)

Description

[Isac Lagerblad (:icaaq)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/16.0 Firefox/16.0a1
Build ID: 20120618030531

Steps to reproduce:

1. Press Cmd+N to open a new browser window, then type https://marketplace.mozilla.org/en-US/ in the address bar and press Enter
2. Inspect eg. #site-header


Actual results:

There are section-elements that is only used for styling purposes.


Expected results:

As the spec says [http://dev.w3.org/html5/spec/the-section-element.html#the-section-element]:
> The section element is not a generic container element. When an element is needed only for styling purposes or as a convenience for scripting, authors are encouraged to use the div element instead. A general rule is that the section element is appropriate only if the element's contents would be listed explicitly in the document's outline.

Therefor a div should be used to center the content instead.

Comment 1

[Wil Clouser [:clouserw]]

Potch, would you confirm/deny this?

Comment 2

[Potch [:potch]]

Fix this in the fixing of the header.

Comment 3

[Potch [:potch]]

We no longer do this in the new header.