The default bug view has changed. See this FAQ.

Preprocess the config file for generated events

RESOLVED FIXED

Status

()

Core
DOM: Events
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

B2G has some events which aren't in FF builds. We should be able to preprocess the
conf file so that we can still autogenerate the code for b2g.
Created attachment 634415 [details] [diff] [review]
patch
Attachment #634415 - Flags: review?(khuey)
https://tbpl.mozilla.org/?tree=Try&rev=77b3b3a3e91e
Comment on attachment 634415 [details] [diff] [review]
patch

Hmm, this wasn't too successful on try
Attachment #634415 - Flags: review?(khuey)
Created attachment 634427 [details] [diff] [review]
patch

Force some dependencies
Attachment #634415 - Attachment is obsolete: true
Attachment #634427 - Flags: review?(khuey)
https://tbpl.mozilla.org/?tree=Try&rev=56b476f67823
Comment on attachment 634427 [details] [diff] [review]
patch

Argh, still no luck
Attachment #634427 - Flags: review?(khuey)
Created attachment 634446 [details] [diff] [review]
patch

This one should work

https://tbpl.mozilla.org/?tree=Try&rev=27f45e15bb5c
Attachment #634427 - Attachment is obsolete: true
Attachment #634446 - Flags: review?(khuey)
Comment on attachment 634446 [details] [diff] [review]
patch

Review of attachment 634446 [details] [diff] [review]:
-----------------------------------------------------------------

Oh nice, you made the changes here I was going to ask for in the other bug.

::: js/xpconnect/src/Makefile.in
@@ +223,5 @@
>  	  -I $(DEPTH)/dist/idl \
>  	  --header-output GeneratedEvents.h \
> +	  event_impl_gen.conf
> +
> +exports:: GeneratedEvents.h

This shouldn't be necessary, since GeneratedEvents.h is in EXPORTS.
Attachment #634446 - Flags: review?(khuey) → review+
Created attachment 644389 [details] [diff] [review]
patch
https://hg.mozilla.org/mozilla-central/rev/b3f2fb31cd77
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.