Closed
Bug 765947
Opened 13 years ago
Closed 13 years ago
Preprocess the config file for generated events
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files, 2 obsolete files)
|
7.44 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
|
7.41 KB,
patch
|
Details | Diff | Splinter Review |
B2G has some events which aren't in FF builds. We should be able to preprocess the
conf file so that we can still autogenerate the code for b2g.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #634415 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 634415 [details] [diff] [review]
patch
Hmm, this wasn't too successful on try
Attachment #634415 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Force some dependencies
Attachment #634415 -
Attachment is obsolete: true
Attachment #634427 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 5•13 years ago
|
||
|
|
Assignee | |
Comment 6•13 years ago
|
||
Comment on attachment 634427 [details] [diff] [review]
patch
Argh, still no luck
Attachment #634427 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 7•13 years ago
|
||
This one should work
https://tbpl.mozilla.org/?tree=Try&rev=27f45e15bb5c
Attachment #634427 -
Attachment is obsolete: true
Attachment #634446 -
Flags: review?(khuey)
Comment on attachment 634446 [details] [diff] [review]
patch
Review of attachment 634446 [details] [diff] [review]:
-----------------------------------------------------------------
Oh nice, you made the changes here I was going to ask for in the other bug.
::: js/xpconnect/src/Makefile.in
@@ +223,5 @@
> -I $(DEPTH)/dist/idl \
> --header-output GeneratedEvents.h \
> + event_impl_gen.conf
> +
> +exports:: GeneratedEvents.h
This shouldn't be necessary, since GeneratedEvents.h is in EXPORTS.
Attachment #634446 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 9•13 years ago
|
||
|
|
Assignee | |
Comment 10•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•