The default bug view has changed. See this FAQ.

Add fail on warnings to some gfx directories

RESOLVED FIXED in mozilla16

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 634255 [details] [diff] [review]
Patch
Attachment #634255 - Flags: review?(bgirard)
Comment on attachment 634255 [details] [diff] [review]
Patch

Nice! I'm happy to take these patch as long as they don't warn anywhere.
Attachment #634255 - Flags: review?(bgirard) → review+
(Assignee)

Updated

5 years ago
Assignee: nobody → dzbarsky
(Assignee)

Comment 2

5 years ago
Created attachment 634670 [details] [diff] [review]
Patch

Fix warnings on gcc
Attachment #634255 - Attachment is obsolete: true
Attachment #634670 - Flags: review?(bgirard)
Comment on attachment 634670 [details] [diff] [review]
Patch

Review of attachment 634670 [details] [diff] [review]:
-----------------------------------------------------------------

http://www.opengl.org/sdk/docs/man/xhtml/glTexImage2D.xml

internalformat should be GLint. Feel free to land the other warning fixes.
Attachment #634670 - Flags: review?(bgirard) → review-
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0ee88e6ac05
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla16
(Assignee)

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
https://hg.mozilla.org/mozilla-central/rev/c0ee88e6ac05
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Hrm, why was the r-'ed patch landed?!
(In reply to Ehsan Akhgari [:ehsan] from comment #6)
> Hrm, why was the r-'ed patch landed?!

It was not. There was one change to make and we discussed it over IRC.

David can you reattach the revised copy on the bug and mention you got r+ from me over IRC for transparency?
(Assignee)

Comment 8

5 years ago
Created attachment 634992 [details] [diff] [review]
Landed patch, r=benwa over irc
Attachment #634670 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.