Last Comment Bug 765989 - Add fail on warnings to some gfx directories
: Add fail on warnings to some gfx directories
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla16
Assigned To: David Zbarsky (:dzbarsky)
: Milan Sreckovic [:milan]
Depends on:
  Show dependency treegraph
Reported: 2012-06-18 17:48 PDT by David Zbarsky (:dzbarsky)
Modified: 2012-06-20 11:50 PDT (History)
3 users (show)
dzbarsky: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (931 bytes, patch)
2012-06-18 17:48 PDT, David Zbarsky (:dzbarsky)
b56girard: review+
Details | Diff | Splinter Review
Patch (6.72 KB, patch)
2012-06-19 17:19 PDT, David Zbarsky (:dzbarsky)
b56girard: review-
Details | Diff | Splinter Review
Landed patch, r=benwa over irc (4.80 KB, patch)
2012-06-20 11:50 PDT, David Zbarsky (:dzbarsky)
no flags Details | Diff | Splinter Review

Description User image David Zbarsky (:dzbarsky) 2012-06-18 17:48:56 PDT
Created attachment 634255 [details] [diff] [review]
Comment 1 User image Benoit Girard (:BenWa) 2012-06-18 18:43:35 PDT
Comment on attachment 634255 [details] [diff] [review]

Nice! I'm happy to take these patch as long as they don't warn anywhere.
Comment 2 User image David Zbarsky (:dzbarsky) 2012-06-19 17:19:47 PDT
Created attachment 634670 [details] [diff] [review]

Fix warnings on gcc
Comment 3 User image Benoit Girard (:BenWa) 2012-06-19 19:50:11 PDT
Comment on attachment 634670 [details] [diff] [review]

Review of attachment 634670 [details] [diff] [review]:

internalformat should be GLint. Feel free to land the other warning fixes.
Comment 4 User image David Zbarsky (:dzbarsky) 2012-06-19 21:14:58 PDT
Comment 6 User image :Ehsan Akhgari 2012-06-20 08:04:30 PDT
Hrm, why was the r-'ed patch landed?!
Comment 7 User image Benoit Girard (:BenWa) 2012-06-20 08:17:13 PDT
(In reply to Ehsan Akhgari [:ehsan] from comment #6)
> Hrm, why was the r-'ed patch landed?!

It was not. There was one change to make and we discussed it over IRC.

David can you reattach the revised copy on the bug and mention you got r+ from me over IRC for transparency?
Comment 8 User image David Zbarsky (:dzbarsky) 2012-06-20 11:50:50 PDT
Created attachment 634992 [details] [diff] [review]
Landed patch, r=benwa over irc

Note You need to log in before you can comment on or make changes to this bug.