Last Comment Bug 766000 - CompositionNotifySink needs a virtual destructor
: CompositionNotifySink needs a virtual destructor
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla16
Assigned To: :Ehsan Akhgari
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-18 18:18 PDT by :Ehsan Akhgari
Modified: 2012-06-20 02:23 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (513 bytes, patch)
2012-06-18 18:19 PDT, :Ehsan Akhgari
joe: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2012-06-18 18:18:29 PDT
PluginStreamParent.cpp
In file included from /Users/ehsanakhgari/moz/mozilla-central/dom/plugins/ipc/PluginInstanceParent.cpp:7:
In file included from /Users/ehsanakhgari/moz/mozilla-central/dom/plugins/ipc/PluginInstanceParent.h:10:
In file included from ../../../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstanceParent.h:9:
In file included from ../../../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstance.h:14:
In file included from ../../../dist/include/IPC/IPCMessageUtils.h:23:
In file included from ../../../dist/include/gfxPattern.h:14:
../../../dist/include/nsAutoPtr.h:71:11: warning: delete called on 'mozilla::layers::CompositionNotifySink' that is abstract but has non-virtual destructor [-Wdelete-non-virtual-dtor]
          delete mRawPtr;
          ^
/Users/ehsanakhgari/moz/mozilla-central/dom/plugins/ipc/PluginInstanceParent.cpp:55:23: note: in instantiation of member function
      'nsAutoPtr<mozilla::layers::CompositionNotifySink>::~nsAutoPtr' requested here
PluginInstanceParent::PluginInstanceParent(PluginModuleParent* parent,
                      ^
Comment 1 :Ehsan Akhgari 2012-06-18 18:19:40 PDT
Created attachment 634261 [details] [diff] [review]
Patch (v1)
Comment 2 Joe Drew (not getting mail) 2012-06-18 18:37:57 PDT
Comment on attachment 634261 [details] [diff] [review]
Patch (v1)

r++++ would review again
Comment 4 Ed Morley [:emorley] 2012-06-20 02:23:00 PDT
https://hg.mozilla.org/mozilla-central/rev/cc5fee7d85c4

Note You need to log in before you can comment on or make changes to this bug.