Closed Bug 766000 Opened 10 years ago Closed 10 years ago

CompositionNotifySink needs a virtual destructor

Categories

(Core :: Graphics: Layers, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

PluginStreamParent.cpp
In file included from /Users/ehsanakhgari/moz/mozilla-central/dom/plugins/ipc/PluginInstanceParent.cpp:7:
In file included from /Users/ehsanakhgari/moz/mozilla-central/dom/plugins/ipc/PluginInstanceParent.h:10:
In file included from ../../../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstanceParent.h:9:
In file included from ../../../ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstance.h:14:
In file included from ../../../dist/include/IPC/IPCMessageUtils.h:23:
In file included from ../../../dist/include/gfxPattern.h:14:
../../../dist/include/nsAutoPtr.h:71:11: warning: delete called on 'mozilla::layers::CompositionNotifySink' that is abstract but has non-virtual destructor [-Wdelete-non-virtual-dtor]
          delete mRawPtr;
          ^
/Users/ehsanakhgari/moz/mozilla-central/dom/plugins/ipc/PluginInstanceParent.cpp:55:23: note: in instantiation of member function
      'nsAutoPtr<mozilla::layers::CompositionNotifySink>::~nsAutoPtr' requested here
PluginInstanceParent::PluginInstanceParent(PluginModuleParent* parent,
                      ^
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #634261 - Flags: review?(joe)
Comment on attachment 634261 [details] [diff] [review]
Patch (v1)

r++++ would review again
Attachment #634261 - Flags: review?(joe) → review+
https://hg.mozilla.org/mozilla-central/rev/cc5fee7d85c4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.