Closed
Bug 766011
Opened 13 years ago
Closed 13 years ago
IonMonkey: Only monitor types in InvokeFunction when necessary
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: dvander, Assigned: dvander)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.06 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
This is small and we really shouldn't have to do this, but it shows up in the richards profile because we don't have polymorphic call inlining yet. It can't hurt.
Attachment #634274 -
Flags: review?(jdemooij)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 634274 [details] [diff] [review]
fix
Flipping review to bhackett as discussed, I'm not entirely sure this always holds.
Attachment #634274 -
Flags: review?(jdemooij) → review?(bhackett1024)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 634274 [details] [diff] [review]
fix
Review of attachment 634274 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/VMFunctions.cpp
@@ +68,5 @@
> + // TI will return false for monitorReturnTypes, meaning there is no
> + // TypeBarrier or Monitor instruction following this. However, we need to
> + // explicitly monitor if the callee has not been analyzed yet. We special
> + // case this to avoid the cost of ion::GetPcScript if we must take this
> + // patch frequently.
s/patch/path
Attachment #634274 -
Flags: review?(bhackett1024) → review+
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•