IonMonkey: Only monitor types in InvokeFunction when necessary

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 634274 [details] [diff] [review]
fix

This is small and we really shouldn't have to do this, but it shows up in the richards profile because we don't have polymorphic call inlining yet. It can't hurt.
Attachment #634274 - Flags: review?(jdemooij)
Comment on attachment 634274 [details] [diff] [review]
fix

Flipping review to bhackett as discussed, I'm not entirely sure this always holds.
Attachment #634274 - Flags: review?(jdemooij) → review?(bhackett1024)
Comment on attachment 634274 [details] [diff] [review]
fix

Review of attachment 634274 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/VMFunctions.cpp
@@ +68,5 @@
> +    // TI will return false for monitorReturnTypes, meaning there is no
> +    // TypeBarrier or Monitor instruction following this. However, we need to
> +    // explicitly monitor if the callee has not been analyzed yet. We special
> +    // case this to avoid the cost of ion::GetPcScript if we must take this
> +    // patch frequently.

s/patch/path
Attachment #634274 - Flags: review?(bhackett1024) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/572de56569fe
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.