Closed Bug 766017 Opened 11 years ago Closed 11 years ago

Fix some skia warnings

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Details

Attachments

(1 file, 1 obsolete file)

Checked in patch
59.91 KB, patch
Details | Diff | Splinter Review
Attached patch Patch (obsolete) — — Splinter Review 
We may want to keep some of the functions since they're part of the API that we don't use, but some can probably be removed.
Attachment #634288 - Flags: review?(jmuizelaar)
Assignee: nobody → dzbarsky
Comment on attachment 634288 [details] [diff] [review]
Patch

These kinds of patches tend to cause needless pain when rebasing upstream projects. It's probably better to submit this directly upstream. George can help with that if needed.
Attachment #634288 - Flags: review?(jmuizelaar) → review-
This doesn't apply against upstream :(
Comment on attachment 634288 [details] [diff] [review]
Patch

Let's land this for now, and we can deal with rebasing later. Please make a diff and put it in the skia/patches directory when you land this.
Attachment #634288 - Flags: review- → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cee44a83f21
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla16
Attached patch Checked in patch — — Splinter Review 

        Attachment #634288 -
        Attachment is obsolete: true

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/9cee44a83f21
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.