Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Fix some skia warnings

RESOLVED FIXED in mozilla16

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 634288 [details] [diff] [review]
Patch

We may want to keep some of the functions since they're part of the API that we don't use, but some can probably be removed.
Attachment #634288 - Flags: review?(jmuizelaar)
(Assignee)

Updated

5 years ago
Assignee: nobody → dzbarsky
Comment on attachment 634288 [details] [diff] [review]
Patch

These kinds of patches tend to cause needless pain when rebasing upstream projects. It's probably better to submit this directly upstream. George can help with that if needed.
Attachment #634288 - Flags: review?(jmuizelaar) → review-
This doesn't apply against upstream :(
Comment on attachment 634288 [details] [diff] [review]
Patch

Let's land this for now, and we can deal with rebasing later. Please make a diff and put it in the skia/patches directory when you land this.
Attachment #634288 - Flags: review- → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cee44a83f21
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla16
(Assignee)

Comment 5

5 years ago
Created attachment 635882 [details] [diff] [review]
Checked in patch
Attachment #634288 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/9cee44a83f21
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.