Closed Bug 766030 Opened 10 years ago Closed 10 years ago

verify.py should run instead of updateSUT/cleanup.py for tegra jobs

Categories

(Release Engineering :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

Details

Attachments

(2 files)

Attached patch [tools] v1Splinter Review
Ok, we should start running verify.py instead of updateSUT/cleanup in here. It will properly set the error.flg and alert us in a good way if stuff goes wonky, instead of letting us fail in a bad way with cleanup.

We currently run cleanup two places, setup and teardown, but this patch will only do verify during setup, and let cleanup.py continue to run after setup, this seems safest until I get some of the flags into verify that make sense to keep us from spending tons of time in here at the end of every job.

(Yes this will mean we do verify actions more than once in some cases, but I feel this is worth it).

First the prelim patch, allow verify.py to get its tegra info from the environment.
Attachment #634306 - Flags: review?(bear)
This patch has not even been run through checkconfig, let alone a dump_master or staging, I will do all of the above before I land though.
Attachment #634309 - Flags: review?(bear)
Comment on attachment 634309 [details] [diff] [review]
[buildbotcustom] v0.5

O too be clear, without redoing how steps are ordered/defined in Talos Factory, I'm stuck doing the verify the same way before and after a job right now.

Changing that is a bit more than I feel we should/need to tackle in this bug/quarter though, so we can address later, if that is ok.
Attachment #634309 - Flags: review?(bear) → review+
Attachment #634306 - Flags: review?(bear) → review+
tools side is deployed now.
Pushed buildbotcustom patch to default, merge at will.

http://hg.mozilla.org/build/buildbotcustom/rev/f5385d109228
This is now live in production.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.