766084 - Add the mozilla-esr10 & fx-team trees to OrangeFactor

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect)

Description

[Ed Morley [:emorley]]

Ok, I know what you are thinking... but we don't care much about ESR right?

Well true, but we're stuck with the virtually unchanged repo for a year, so it would be nice to identify the top oranges (that we still end up having to star) and uplift any test-only fixes for them (/just disable the things).

At the moment I have no easy way of working out what are the top failures in order to do this.

Comment 1

[Ed Morley [:emorley]]

mcote, I presume this just needs mozilla-esr10 adding to server/orangefactor.conf on prod+stage yeah?

Comment 2

[Jonathan Griffin (:jgriffin)]

We'll also need to add the mozilla-esr branch to the WOO logparser.

Comment 3

[Ed Morley [:emorley]]

(In reply to Jonathan Griffin (:jgriffin) from comment #2)
> We'll also need to add the mozilla-esr branch to the WOO logparser.

Is that in another repo?

Comment 4

[Jonathan Griffin (:jgriffin)]

(In reply to Ed Morley [:edmorley] from comment #3)
> (In reply to Jonathan Griffin (:jgriffin) from comment #2)
> > We'll also need to add the mozilla-esr branch to the WOO logparser.
> 
> Is that in another repo?

I meant mozilla-esr10, http://hg.mozilla.org/releases/mozilla-esr10/.  We're currently not parsing logs from tests on this repo, so we'll have to start doing that.

Comment 5

[Ed Morley [:emorley]]

Sorry, by 'it' I was referring to the text "WOO logparser", since my search of the orangefactor repo hadn't found a log parser.

Comment 6

[Jonathan Griffin (:jgriffin)]

(In reply to Ed Morley [:edmorley] from comment #5)
> Sorry, by 'it' I was referring to the text "WOO logparser", since my search
> of the orangefactor repo hadn't found a log parser.

Ah yes, that lives at http://hg.mozilla.org/automation/logparser/

Comment 7

[Ed Morley [:emorley]]

Ah, thank you.

I've just had a look, and I spotted the 'pine' repo is listed there:
http://hg.mozilla.org/automation/logparser/file/25c47477904c/logparser/config.py#l25

Do we still need that?
Perhaps we could s/pine/fx-team/ and add mozilla-esr10 ?

Comment 8

[Jonathan Griffin (:jgriffin)]

(In reply to Ed Morley [:edmorley] from comment #7)
> Ah, thank you.
> 
> I've just had a look, and I spotted the 'pine' repo is listed there:
> http://hg.mozilla.org/automation/logparser/file/25c47477904c/logparser/
> config.py#l25
> 
> Do we still need that?
> Perhaps we could s/pine/fx-team/ and add mozilla-esr10 ?

We don't need pine.  Those changes would be fine with me.

Comment 9

[Ed Morley [:emorley]]

Attachment: Logparser changes

Comment 10

[Ed Morley [:emorley]]

Attachment: orangefactor.conf.example changes

+Removes 'places', since no longer used.

We'll need to update the live copy of orangefactor.conf on dev/staging/prod too :-)

Comment 11

[Jonathan Griffin (:jgriffin)]

Comment on attachment 650104 [details] [diff] [review]
orangefactor.conf.example changes

Review of attachment 650104 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 12

[Jonathan Griffin (:jgriffin)]

(In reply to Jonathan Griffin (:jgriffin) from comment #11)
> Comment on attachment 650104 [details] [diff] [review]
> orangefactor.conf.example changes
> 
> Review of attachment 650104 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, thanks!

Landed as http://hg.mozilla.org/automation/orangefactor/rev/f7fbe255bfc9, and deployed on the server.  Note that the new trees will have to be added to http://hg.mozilla.org/automation/orangefactor/file/f7fbe255bfc9/html/scripts/woo.utils.js#l27 in order for them to appear in the dropdown in the UI.  But the data for the new trunk_trees is already present when viewing "Trunk" data in the UI.

Comment 13

[Ed Morley [:emorley]]

Comment on attachment 650099 [details] [diff] [review]
Logparser changes

Oops, forgot to request review for this one.

Comment 14

[Ed Morley [:emorley]]

Attachment: Update branches in woo.utils.js

Thank you, forgot about the client-side changes :-)

Comment 15

[Jonathan Griffin (:jgriffin)]

Comment on attachment 650099 [details] [diff] [review]
Logparser changes

Landed as http://hg.mozilla.org/automation/logparser/rev/025da2685aeb and deployed.

Comment 16

[Jonathan Griffin (:jgriffin)]

Comment on attachment 650505 [details] [diff] [review]
Update branches in woo.utils.js

Landed as http://hg.mozilla.org/automation/orangefactor/rev/aeff407a34c5 and deployed.  You may have to shift+reload to pick up the changes.

Comment 17

[Ed Morley [:emorley]]

Thank you :-)