766094 - Disable telemetry prompt on chrome-less application launch

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (06/19) Screenshot

See screenshot.


Looks a tad out of place. Do we want to still offer this? Stifle it?

Comment 1

[Jason Smith [:jsmith]]

Does this show up on the first time you launch any web app? Or does this show up once ever? Looking to understand the frequency of this happening.

Comment 2

[Aaron Train [:aaronmt]]

STR:

i) Opt-in via popup on first launch of Nightly 
ii) Install an application; launch via shortcut

ER: No prompt
AR: Telemetry prompt 

Essentially we are asked twice. If you opt-no in the application launcher you won't see it again.

Comment 3

[Lawrence Mandel [:lmandel] (use needinfo)]

We haven't decided how users should opt-in to Telemetry in WebRT. I would suggest that the popup not be shown in the WebRT at this point.

Comment 4

[(dormant account)]

(In reply to Lawrence Mandel [:lmandel] from comment #3)
> We haven't decided how users should opt-in to Telemetry in WebRT. I would
> suggest that the popup not be shown in the WebRT at this point.

So how do we gather telemetry? Inherit optin from firefox prefs?

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Taras Glek (:taras) from comment #4)
> (In reply to Lawrence Mandel [:lmandel] from comment #3)
> > We haven't decided how users should opt-in to Telemetry in WebRT. I would
> > suggest that the popup not be shown in the WebRT at this point.
> 
> So how do we gather telemetry? Inherit optin from firefox prefs?

That's one solution that has been proposed. We should come up with some options and make a decision on this so that we can ensure that we can collect Telemetry data in WebRT.

Comment 6

[(dormant account)]

My preferred way to do telemetry in apps is to prompt as part of install experience within Firefox with
[x] submit telemetry data yadda yadda
Apps telemetry should also report application id of some sort. This would be a killer feature for both app developers to see what sort of perf their users are experiencing and for us to be able to track performance on a per-site basis. 

Alternatively, I would settle for inheriting telemetry for now and moving to above model in a subsequent release.

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Patch

This should work, but I can't for the life of me get the telemetry prompt to show.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #2)
> STR:
> 
> i) Opt-in via popup on first launch of Nightly 
> ii) Install an application; launch via shortcut
> 
> ER: No prompt
> AR: Telemetry prompt 
> 
> Essentially we are asked twice. If you opt-no in the application launcher
> you won't see it again.

This happens because every webapp is run in a separate profile. Therefore, we prompt for each webapp. We would do the same thing if users could create new profiles in Fennec.

(In reply to Taras Glek (:taras) from comment #4)
> (In reply to Lawrence Mandel [:lmandel] from comment #3)
> > We haven't decided how users should opt-in to Telemetry in WebRT. I would
> > suggest that the popup not be shown in the WebRT at this point.
> 
> So how do we gather telemetry? Inherit optin from firefox prefs?

We would only inherit the current state when a webapp is installed. If the user changes the telemetry setting in Fennec, the data is not pushed to existing webapps.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 634633 [details] [diff] [review]
Patch

While this approach works, let's switch to inheriting the Fennec preference. I think you have a patch to make default prefs in bug 766297. Let's build on that approach.

Comment 10

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

I have started a discussion about Telemetry opt-in for WebRT on dev-planning.

https://groups.google.com/forum/?fromgroups#!topic/mozilla.dev.planning/I6DmNxjvqCI

Comment 12

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/47488847428f

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/47488847428f

Comment 14

[Jason Smith [:jsmith]]

This isn't working for me on Nightly (7/8/2012) on a Galaxy Nexus. I installed two different apps on testmanifest.com and launched them. Both times I got the telemetry prompt, even though I already made a decision at the telemetry prompt when I originally started Nightly.

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Jason Smith [:jsmith] from comment #14)
> This isn't working for me on Nightly (7/8/2012) on a Galaxy Nexus. I
> installed two different apps on testmanifest.com and launched them. Both
> times I got the telemetry prompt, even though I already made a decision at
> the telemetry prompt when I originally started Nightly.

The patch should just disable the telemetry prompt. It does not inherit the current setting in Firefox.

Since it is not disabling the prompt, Wes should take a look to see what's happening.

Comment 16

[Sid Stamm [:geekboy or :sstamm]]

(In reply to Mark Finkle (:mfinkle) from comment #15)
> The patch should just disable the telemetry prompt. It does not inherit the
> current setting in Firefox.

This sounds different than the approach you mentioned in comment 9 and this bug is marked as fixed, so I'm a bit confused.  Should this bug should be called "disable telemetry prompt on chrome-less applications" or is there still work to do on this bug?

Comment 17

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Sid Stamm [:geekboy] from comment #16)

> This sounds different than the approach you mentioned in comment 9 and this
> bug is marked as fixed, so I'm a bit confused.  Should this bug should be
> called "disable telemetry prompt on chrome-less applications" or is there
> still work to do on this bug?

(In reply to Lawrence Mandel [:lmandel] from comment #11)
> I have started a discussion about Telemetry opt-in for WebRT on dev-planning.
> 
> https://groups.google.com/forum/?fromgroups#!topic/mozilla.dev.planning/
> I6DmNxjvqCI

Right. Let's open a new bug to implement whatever comes out of lmandel's thread.

Comment 18

[Aaron Train [:aaronmt]]

I still get telemetry prompts on launching web-apps.

STR

i) Launch Nightly, opt-out.
ii) testmanifest.com, install
iii) Launch installed app via shortcut

AR: Telemetry prompt
ER: No prompt

Comment 19

[Wesley Johnston (:wesj)]

Attachment: JS Patch

Set these up on first-run in WebAppsRT.js. I removed some of the prefs that I copied from desktop and had no idea why we'd want. We may eventually want to change our blocklist url ping, but I figured we can do that in a separate bug.

Comment 20

[Wesley Johnston (:wesj)]

Grr. Removed the old prefs file, but forgot to remove the old code copying it into the profile.... I'll just do two patches.

Comment 21

[Wesley Johnston (:wesj)]

Attachment: Patch 2/2

This reverts the rest of the changes from bug 766297.

Comment 22

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 643697 [details] [diff] [review]
JS Patch

The way you are doing the prefs will make them treated as "user changed". I'm not sure this will be an issue or not, but it will make any "restore to default" action non-trivial.

I also wanted to point out the the end goal of the telemetry prompt is to use whatever Firefox is currently using. That will be difficult using this approach since you don't have access to the prefs file. Maybe you could write out a weabpp_prefs.json file when we install the app and then read it in WebAppRT.init ?

This patch should work well enough to start.

Comment 23

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 643885 [details] [diff] [review]
Patch 2/2

Hmm, we might want this support again. If we don't need it right now, OK.

Comment 24

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eed94b0e2d4a

Comment 25

[Wesley Johnston (:wesj)]

Comment on attachment 643697 [details] [diff] [review]
JS Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature
User impact if declined: Our default prefs on webapps aren't working at all.
Testing completed (on m-c, etc.): Landed on mc Jul 19
Risk to taking this patch (and alternatives if risky): Low risk. mobile webapps only.
String or UUID changes made by this patch:  none.

Comment 26

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/eed94b0e2d4a

Comment 27

[Jason Smith [:jsmith]]

Tested on the latest nightly on a galaxy nexus - this still isn't working. I get the telemetry prompt to come up immediately after installing and launching an app from the notification. Reopening again.

Comment 28

[Aaron Train [:aaronmt]]

Reproducible with Nightly (07/23) (Galaxy SII/4.0.4)

Comment 29

[Wesley Johnston (:wesj)]

Grr. the landed patch isn't quite the same as the r+ one. Telemetry is running before we hit init right now. Since that patch is r+, I'll push a fix. Sorry bout that... :(

Comment 30

[Wesley Johnston (:wesj)]

Attachment: Patch 3/2

No, I'm just dumb here. This pref is an int.

Comment 31

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b7ad22a0b13

Comment 32

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2b7ad22a0b13

Comment 33

[Jason Smith [:jsmith]]

Feel free to nominate the remaining patches for Aurora uplift.

Comment 34

[Wesley Johnston (:wesj)]

Comment on attachment 643885 [details] [diff] [review]
Patch 2/2

Yeah, these should move forward

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New Webapps stuff
User impact if declined: Annoying telemetry prompt
Testing completed (on m-c, etc.): Landed on mc awhile ago. 
Risk to taking this patch (and alternatives if risky): Low risk
String or UUID changes made by this patch: None.

Comment 35

[Wesley Johnston (:wesj)]

Comment on attachment 645119 [details] [diff] [review]
Patch 3/2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New Webapps stuff
User impact if declined: Annoying telemetry prompt
Testing completed (on m-c, etc.): Landed on mc awhile ago. 
Risk to taking this patch (and alternatives if risky): Low risk
String or UUID changes made by this patch: None.

Comment 36

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/12a2e9a56100