Last Comment Bug 766250 - Enable more release-time jemalloc assertions
: Enable more release-time jemalloc assertions
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Memory Allocator (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla16
Assigned To: Justin Lebar (not reading bugmail)
:
: Mike Hommey [:glandium]
Mentors:
Depends on: jemalloc-assertions
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-19 12:19 PDT by Justin Lebar (not reading bugmail)
Modified: 2012-06-20 08:02 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part 1: Enable more release-time jemalloc assertions. (6.81 KB, patch)
2012-06-19 12:32 PDT, Justin Lebar (not reading bugmail)
mh+mozilla: review+
Details | Diff | Splinter Review
Part 2: Split MOZ_TEMP_INVESTIGATION into MOZ_TEMP_INVESTIGATION and MOZ_JEMALLOC_HARD_ASSERTS. (4.63 KB, patch)
2012-06-19 12:32 PDT, Justin Lebar (not reading bugmail)
mh+mozilla: review+
Details | Diff | Splinter Review

Description Justin Lebar (not reading bugmail) 2012-06-19 12:19:12 PDT
Bug 764192 was pretty successful.  Even if it didn't find bug 709860, it immediately pointed us to a double-free.

There are some additional assertions in jemalloc which I didn't enable because they're not related to bug 709860.  But given how useful the assertions we've turned on have been, I think we might as well enable some more.  I doubt there will be any measurable performance implications here.
Comment 1 Justin Lebar (not reading bugmail) 2012-06-19 12:32:06 PDT
Created attachment 634547 [details] [diff] [review]
Part 1: Enable more release-time jemalloc assertions.
Comment 2 Justin Lebar (not reading bugmail) 2012-06-19 12:32:31 PDT
Created attachment 634548 [details] [diff] [review]
Part 2: Split MOZ_TEMP_INVESTIGATION into MOZ_TEMP_INVESTIGATION and MOZ_JEMALLOC_HARD_ASSERTS.

MOZ_TEMP_INVESTIGATION is temporary, but I'm thinking now that MOZ_JEMALLOC_HARD_ASSERTS should not be.
Comment 3 Justin Lebar (not reading bugmail) 2012-06-19 12:39:55 PDT
https://tbpl.mozilla.org/?tree=Try&rev=155fb714669a

Note You need to log in before you can comment on or make changes to this bug.