Closed Bug 766250 Opened 10 years ago Closed 10 years ago

Enable more release-time jemalloc assertions

Categories

(Core :: Memory Allocator, defect)

Product:
Core
Component:
Memory Allocator
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

Attachments

(2 files)

Part 1: Enable more release-time jemalloc assertions.
6.81 KB, patch
glandium
: review+
Details | Diff | Splinter Review
Part 2: Split MOZ_TEMP_INVESTIGATION into MOZ_TEMP_INVESTIGATION and MOZ_JEMALLOC_HARD_ASSERTS.
4.63 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
Bug 764192 was pretty successful.  Even if it didn't find bug 709860, it immediately pointed us to a double-free.

There are some additional assertions in jemalloc which I didn't enable because they're not related to bug 709860.  But given how useful the assertions we've turned on have been, I think we might as well enable some more.  I doubt there will be any measurable performance implications here.
Assignee: nobody → justin.lebar+bug
MOZ_TEMP_INVESTIGATION is temporary, but I'm thinking now that MOZ_JEMALLOC_HARD_ASSERTS should not be.
Attachment #634548 - Flags: review?(mh+mozilla)
Attachment #634547 - Flags: review?(mh+mozilla) → review+
Attachment #634548 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/cc36f28dad83
https://hg.mozilla.org/mozilla-central/rev/4a44ebe3e8ff
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.