|
6.81 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
|
4.63 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Bug 764192 was pretty successful. Even if it didn't find bug 709860, it immediately pointed us to a double-free. There are some additional assertions in jemalloc which I didn't enable because they're not related to bug 709860. But given how useful the assertions we've turned on have been, I think we might as well enable some more. I doubt there will be any measurable performance implications here.
|
(Assignee) | |
Updated•5 years ago
|
||
|
|
(Assignee) | |
Comment 1•5 years ago
|
||
Created attachment 634547 [details] [diff] [review] Part 1: Enable more release-time jemalloc assertions.
|
|
(Assignee) | |
Comment 2•5 years ago
|
||
Created attachment 634548 [details] [diff] [review] Part 2: Split MOZ_TEMP_INVESTIGATION into MOZ_TEMP_INVESTIGATION and MOZ_JEMALLOC_HARD_ASSERTS. MOZ_TEMP_INVESTIGATION is temporary, but I'm thinking now that MOZ_JEMALLOC_HARD_ASSERTS should not be.
|
|
(Assignee) | |
Comment 3•5 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=155fb714669a
|
||
Updated•5 years ago
|
||
|
|
||
Updated•5 years ago
|
||
|
|
(Assignee) | |
Comment 4•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc36f28dad83 https://hg.mozilla.org/integration/mozilla-inbound/rev/4a44ebe3e8ff
https://hg.mozilla.org/mozilla-central/rev/cc36f28dad83 https://hg.mozilla.org/mozilla-central/rev/4a44ebe3e8ff
Description
•