766250 - Enable more release-time jemalloc assertions

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Justin Lebar (not reading bugmail)]

Bug 764192 was pretty successful.  Even if it didn't find bug 709860, it immediately pointed us to a double-free.

There are some additional assertions in jemalloc which I didn't enable because they're not related to bug 709860.  But given how useful the assertions we've turned on have been, I think we might as well enable some more.  I doubt there will be any measurable performance implications here.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Part 1: Enable more release-time jemalloc assertions.

Comment 2

[Justin Lebar (not reading bugmail)]

Attachment: Part 2: Split MOZ_TEMP_INVESTIGATION into MOZ_TEMP_INVESTIGATION and MOZ_JEMALLOC_HARD_ASSERTS.

MOZ_TEMP_INVESTIGATION is temporary, but I'm thinking now that MOZ_JEMALLOC_HARD_ASSERTS should not be.

Comment 3

[Justin Lebar (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Try&rev=155fb714669a

Comment 4

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc36f28dad83
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a44ebe3e8ff

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/cc36f28dad83
https://hg.mozilla.org/mozilla-central/rev/4a44ebe3e8ff