The default bug view has changed. See this FAQ.

Enable more release-time jemalloc assertions

RESOLVED FIXED in mozilla16

Status

()

Core
Memory Allocator
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

Trunk
mozilla16
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Bug 764192 was pretty successful.  Even if it didn't find bug 709860, it immediately pointed us to a double-free.

There are some additional assertions in jemalloc which I didn't enable because they're not related to bug 709860.  But given how useful the assertions we've turned on have been, I think we might as well enable some more.  I doubt there will be any measurable performance implications here.
(Assignee)

Updated

5 years ago
Assignee: nobody → justin.lebar+bug
(Assignee)

Updated

5 years ago
Depends on: 764192
(Assignee)

Comment 1

5 years ago
Created attachment 634547 [details] [diff] [review]
Part 1: Enable more release-time jemalloc assertions.
Attachment #634547 - Flags: review?(mh+mozilla)
(Assignee)

Comment 2

5 years ago
Created attachment 634548 [details] [diff] [review]
Part 2: Split MOZ_TEMP_INVESTIGATION into MOZ_TEMP_INVESTIGATION and MOZ_JEMALLOC_HARD_ASSERTS.

MOZ_TEMP_INVESTIGATION is temporary, but I'm thinking now that MOZ_JEMALLOC_HARD_ASSERTS should not be.
Attachment #634548 - Flags: review?(mh+mozilla)
(Assignee)

Comment 3

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=155fb714669a
Attachment #634547 - Flags: review?(mh+mozilla) → review+
Attachment #634548 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc36f28dad83
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a44ebe3e8ff
https://hg.mozilla.org/mozilla-central/rev/cc36f28dad83
https://hg.mozilla.org/mozilla-central/rev/4a44ebe3e8ff
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.