Last Comment Bug 766253 - libyuv (imported with WebRTC) uses uint8 with signed initializers
: libyuv (imported with WebRTC) uses uint8 with signed initializers
Status: RESOLVED FIXED
[qa-]
:
Product: Core
Classification: Components
Component: WebRTC: Audio/Video (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: [:jesup] on pto until 2016/7/5 Randell Jesup
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-19 12:23 PDT by [:jesup] on pto until 2016/7/5 Randell Jesup
Modified: 2012-07-27 10:23 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Simple fix (978 bytes, patch)
2012-06-19 12:23 PDT, [:jesup] on pto until 2016/7/5 Randell Jesup
tterribe: review+
Details | Diff | Review

Description [:jesup] on pto until 2016/7/5 Randell Jesup 2012-06-19 12:23:44 PDT
Created attachment 634540 [details] [diff] [review]
Simple fix

In webrtc.org's tracker as bug 188; trivial patch.
http://code.google.com/p/webrtc/issues/detail?id=188
Comment 1 Timothy B. Terriberry (:derf) 2012-06-19 12:27:15 PDT
Comment on attachment 634540 [details] [diff] [review]
Simple fix

Review of attachment 634540 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/third_party/libyuv/source/row_posix.cc
@@ +27,5 @@
>  CONST vec8 kARGBToU = {
>    112, -74, -38, 0, 112, -74, -38, 0, 112, -74, -38, 0, 112, -74, -38, 0
>  };
>  
> +CONST vec8 kARGBToV = {

I'd argue that using negative numbers in an initializer for an unsigned value is just as broken, but...
Comment 2 Timothy B. Terriberry (:derf) 2012-06-19 12:29:25 PDT
Err, ignore the comment. I was reading the diff backwards. Still r+.
Comment 3 [:jesup] on pto until 2016/7/5 Randell Jesup 2012-06-20 05:26:31 PDT
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=1e066a4b6176
Comment 4 [:jesup] on pto until 2016/7/5 Randell Jesup 2012-06-21 06:53:11 PDT
Relanding:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2ad9ba0e0ccb
Comment 5 Ed Morley [:emorley] 2012-06-21 13:04:27 PDT
https://hg.mozilla.org/mozilla-central/rev/d622728e847a

Note You need to log in before you can comment on or make changes to this bug.