Closed
Bug 766253
Opened 12 years ago
Closed 12 years ago
libyuv (imported with WebRTC) uses uint8 with signed initializers
Categories
(Core :: WebRTC: Audio/Video, defect)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jesup, Assigned: jesup)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
978 bytes,
patch
|
derf
:
review+
|
Details | Diff | Splinter Review |
In webrtc.org's tracker as bug 188; trivial patch.
http://code.google.com/p/webrtc/issues/detail?id=188
Attachment #634540 -
Flags: review?(tterribe)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 634540 [details] [diff] [review]
Simple fix
Review of attachment 634540 [details] [diff] [review]:
-----------------------------------------------------------------
::: media/webrtc/trunk/third_party/libyuv/source/row_posix.cc
@@ +27,5 @@
> CONST vec8 kARGBToU = {
> 112, -74, -38, 0, 112, -74, -38, 0, 112, -74, -38, 0, 112, -74, -38, 0
> };
>
> +CONST vec8 kARGBToV = {
I'd argue that using negative numbers in an initializer for an unsigned value is just as broken, but...
Attachment #634540 -
Flags: review?(tterribe) → review+
|
|
||
Comment 2•12 years ago
|
||
Err, ignore the comment. I was reading the diff backwards. Still r+.
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
|
||
Updated•12 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•