B2G telephony on Otoro: Can't hang up dialing call

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: philikon, Assigned: hsinyi)

Tracking

unspecified
mozilla16
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(blocking-kilimanjaro:+, blocking-basecamp:+)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

STR:

1. Dial a number.
2. Hang up while it's still ringing (don't wait for the other side to pick up.)
3. Dialed phone keeps ringing.

Seems like the Otoro RIL isn't too happy about using REQUEST_HANGUP_FOREGROUND_RESUME_BACKGROUND for dialing calls:

I/Gecko   (  115): RIL Worker: Solicited response for request type 14, token 87, error 2
I/Gecko   (  115): RIL Worker: Handling parcel as REQUEST_HANGUP_FOREGROUND_RESUME_BACKGROUND

Updated

5 years ago
blocking-basecamp: ? → +
blocking-kilimanjaro: ? → +
Hsinyi, would you mind taking a look at this?
Assignee: nobody → htsai
(Assignee)

Comment 2

5 years ago
(In reply to Philipp von Weitershausen [:philikon] from comment #1)
> Hsinyi, would you mind taking a look at this?
Sure! Just got a new phone and will take care of this.
(Assignee)

Comment 3

5 years ago
Created attachment 634836 [details] [diff] [review]
patch

Philipp, you're right. Too bad that Otoro doesn't like REQUEST_HANGUP_FOREGROUND_RESUME_BACKGROUND. The patch fixes this.
Attachment #634836 - Flags: review?(philipp)
Comment on attachment 634836 [details] [diff] [review]
patch

Looks good. Thanks!

Unrelated to this Otoro-specific issue: It occurred to me that we don't have tests for some of these scenarios, e.g. hanging up a dialing call. Would you mind writing some? (Can do it in a follow-up.)
Attachment #634836 - Flags: review?(philipp) → review+
(Assignee)

Comment 5

5 years ago
(In reply to Philipp von Weitershausen [:philikon] from comment #4)
> Comment on attachment 634836 [details] [diff] [review]
> patch
> 
> Looks good. Thanks!
> 
> Unrelated to this Otoro-specific issue: It occurred to me that we don't have
> tests for some of these scenarios, e.g. hanging up a dialing call. Would you
> mind writing some? (Can do it in a follow-up.)
I filed bug 766822 for these test cases. Let's move there for related discussion.
(Assignee)

Comment 6

5 years ago
Try server result https://tbpl.mozilla.org/?tree=Try&rev=d498ea306a23
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/96eb15859e36
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/96eb15859e36
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
John - Can you verify this fix when an otoro build is available?
Whiteboard: [qa+]
A new bug has been reported after applying this patch in Otoro
https://bugzilla.mozilla.org/show_bug.cgi?id=768878
You need to log in before you can comment on or make changes to this bug.