Last Comment Bug 766273 - B2G telephony on Otoro: Can't hang up dialing call
: B2G telephony on Otoro: Can't hang up dialing call
Status: RESOLVED FIXED
[qa+]
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla16
Assigned To: Hsin-Yi Tsai [:hsinyi]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: b2g-telephony
  Show dependency treegraph
 
Reported: 2012-06-19 13:00 PDT by Philipp von Weitershausen [:philikon]
Modified: 2012-06-27 08:06 PDT (History)
8 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
+
+


Attachments
patch (1.35 KB, patch)
2012-06-20 03:58 PDT, Hsin-Yi Tsai [:hsinyi]
philipp: review+
Details | Diff | Splinter Review

Description Philipp von Weitershausen [:philikon] 2012-06-19 13:00:38 PDT
STR:

1. Dial a number.
2. Hang up while it's still ringing (don't wait for the other side to pick up.)
3. Dialed phone keeps ringing.

Seems like the Otoro RIL isn't too happy about using REQUEST_HANGUP_FOREGROUND_RESUME_BACKGROUND for dialing calls:

I/Gecko   (  115): RIL Worker: Solicited response for request type 14, token 87, error 2
I/Gecko   (  115): RIL Worker: Handling parcel as REQUEST_HANGUP_FOREGROUND_RESUME_BACKGROUND
Comment 1 Philipp von Weitershausen [:philikon] 2012-06-19 17:46:02 PDT
Hsinyi, would you mind taking a look at this?
Comment 2 Hsin-Yi Tsai [:hsinyi] 2012-06-19 19:17:19 PDT
(In reply to Philipp von Weitershausen [:philikon] from comment #1)
> Hsinyi, would you mind taking a look at this?
Sure! Just got a new phone and will take care of this.
Comment 3 Hsin-Yi Tsai [:hsinyi] 2012-06-20 03:58:44 PDT
Created attachment 634836 [details] [diff] [review]
patch

Philipp, you're right. Too bad that Otoro doesn't like REQUEST_HANGUP_FOREGROUND_RESUME_BACKGROUND. The patch fixes this.
Comment 4 Philipp von Weitershausen [:philikon] 2012-06-20 16:43:11 PDT
Comment on attachment 634836 [details] [diff] [review]
patch

Looks good. Thanks!

Unrelated to this Otoro-specific issue: It occurred to me that we don't have tests for some of these scenarios, e.g. hanging up a dialing call. Would you mind writing some? (Can do it in a follow-up.)
Comment 5 Hsin-Yi Tsai [:hsinyi] 2012-06-20 19:23:49 PDT
(In reply to Philipp von Weitershausen [:philikon] from comment #4)
> Comment on attachment 634836 [details] [diff] [review]
> patch
> 
> Looks good. Thanks!
> 
> Unrelated to this Otoro-specific issue: It occurred to me that we don't have
> tests for some of these scenarios, e.g. hanging up a dialing call. Would you
> mind writing some? (Can do it in a follow-up.)
I filed bug 766822 for these test cases. Let's move there for related discussion.
Comment 6 Hsin-Yi Tsai [:hsinyi] 2012-06-21 18:31:51 PDT
Try server result https://tbpl.mozilla.org/?tree=Try&rev=d498ea306a23
Comment 8 Ed Morley [:emorley] 2012-06-22 09:17:13 PDT
https://hg.mozilla.org/mozilla-central/rev/96eb15859e36
Comment 9 Jason Smith [:jsmith] 2012-06-26 23:09:50 PDT
John - Can you verify this fix when an otoro build is available?
Comment 10 Maria Angeles Oteo (:oteo) 2012-06-27 08:06:46 PDT
A new bug has been reported after applying this patch in Otoro
https://bugzilla.mozilla.org/show_bug.cgi?id=768878

Note You need to log in before you can comment on or make changes to this bug.