766285 - Exception opening webapp from its install notification

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Wesley Johnston (:wesj)]

void mozilla::AndroidBridge::HandleGeckoMessage(const nsAString_internal&, nsAString_internal&)
GeckoApp: Got message: WebApps:Open
GeckoApp: Exception handling message "WebApps:Open":
GeckoApp: org.json.JSONException: No value for origin
GeckoApp: 	at org.json.JSONObject.get(JSONObject.java:354)
GeckoApp: 	at org.json.JSONObject.getString(JSONObject.java:510)
GeckoApp: 	at org.mozilla.gecko.GeckoApp.handleMessage(GeckoApp.java:1169)
GeckoApp: 	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:1884)
GeckoApp: 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
GeckoApp: 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
GeckoApp: 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:476)
GeckoApp: 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:90)

Comment 1

[Jason Smith [:jsmith]]

From the end-user perspective, does the exception impact anything towards the user? Or does this just happen in the background with no end-user impact?

Comment 2

[Wesley Johnston (:wesj)]

The app doesn't launch (like a system app install would).

Comment 3

[Jason Smith [:jsmith]]

Nominating for k9o - blocks part of the basic install flow for a web app.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

Tiny tweak.

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4139e414c92c

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4139e414c92c

Comment 7

[Aaron Train [:aaronmt]]

Works now; verified fixed.

--
Galaxy Nexus (Android 4.0.4)
Inbound (06.21)