766298 - Implement InvalidateFrameSubtree in terms of InvalidateOverflowRect

Status: RESOLVED WONTFIX

(Core :: Layout, defect)

Description

[(no longer active)]

void
nsIFrame::InvalidateFrameSubtree()
{
  Invalidate(GetVisualOverflowRectRelativeToSelf());
  FrameLayerBuilder::InvalidateThebesLayersInSubtree(this);
}

void
nsIFrame::InvalidateOverflowRect()
{
  Invalidate(GetVisualOverflowRectRelativeToSelf());
}

This duplication of the call to Invalidate makes very little sense.

Comment 1

[Jignesh Kakadiya [:jhk]]

Attachment: Patch(v1)

Comment 2

[(no longer active)]

Comment on attachment 635237 [details] [diff] [review]
Patch(v1)

Review of attachment 635237 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 635237 [details] [diff] [review]
Patch(v1)

Review of attachment 635237 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, no.

The patch is fine, but this code goes away with DLBI and the only effect of landing it will be to cause mattwoodrow more rebase churn. Let's not do that.

If the patch had some positive effect other than minor code cleanup, I wouldn't do this, but it doesn't.

Comment 4

[(no longer active)]

Right.  Sorry Jignesh, I should have realized this before...