If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Implement InvalidateFrameSubtree in terms of InvalidateOverflowRect

RESOLVED WONTFIX

Status

()

Core
Layout
RESOLVED WONTFIX
5 years ago
5 years ago

People

(Reporter: Away for a while, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=ehsan][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
void
nsIFrame::InvalidateFrameSubtree()
{
  Invalidate(GetVisualOverflowRectRelativeToSelf());
  FrameLayerBuilder::InvalidateThebesLayersInSubtree(this);
}

void
nsIFrame::InvalidateOverflowRect()
{
  Invalidate(GetVisualOverflowRectRelativeToSelf());
}

This duplication of the call to Invalidate makes very little sense.
(Reporter)

Updated

5 years ago
Whiteboard: [mentor=ehsan][lang=c++]
Created attachment 635237 [details] [diff] [review]
Patch(v1)
Attachment #635237 - Flags: feedback?(ehsan)
(Reporter)

Comment 2

5 years ago
Comment on attachment 635237 [details] [diff] [review]
Patch(v1)

Review of attachment 635237 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!
Attachment #635237 - Flags: review?(roc)
Attachment #635237 - Flags: feedback?(ehsan)
Attachment #635237 - Flags: feedback+
Attachment #635237 - Flags: review?(roc) → review+
Comment on attachment 635237 [details] [diff] [review]
Patch(v1)

Review of attachment 635237 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, no.

The patch is fine, but this code goes away with DLBI and the only effect of landing it will be to cause mattwoodrow more rebase churn. Let's not do that.

If the patch had some positive effect other than minor code cleanup, I wouldn't do this, but it doesn't.
Attachment #635237 - Flags: review+ → review-
(Reporter)

Comment 4

5 years ago
Right.  Sorry Jignesh, I should have realized this before...
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.