766299 - Pop-up windows outside of the main app window need to be shown as so, along with ability to close them

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P2)

Description

[Jason Smith [:jsmith]]

Steps:

1. Go to apps.mozillalabs.com/appdir
2. Install Mozilla QA WebRT Tester
3. Go to firefox --> popups --> popup trigger
4. Select show when the prompt for the pop-up appears

Expected:

A pop-up dialog with chrome should appear that allows the pop-up to be closed to return to the main app window.

Actual:

The pop-up does appear, but there's no chrome shown, so how would a user know how to get rid of the pop-up? A work-around would be using the back button until the pop-up disappears, but that's not intuitive. We should show chrome indicating that it is a pop-up and that it can be closed.

Comment 1

[Jason Smith [:jsmith]]

k9o nomination - pop-ups exist for various auth methods, including BID for marketplace. We're definitely going to need this.

Comment 2

[Wesley Johnston (:wesj)]

My initial thought is that we add a menu option to bring up the tab switcher UI (its been changing recently, so I'll have to look into if that's still feasible).

Comment 3

[Asa Dotzler [:asa]]

solving this problem is a k90 requirement

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Wesley Johnston (:wesj) from comment #2)
> My initial thought is that we add a menu option to bring up the tab switcher
> UI (its been changing recently, so I'll have to look into if that's still
> feasible).

Correct. Fennec on Android does not show popups in new windows. We show them in new tabs. Therefore, we need a way to view and close tabs.

Comment 5

[Wesley Johnston (:wesj)]

Attachment: WIP Patch

Saving my place. This brings over our Tabs ui from Firefox (i.e. the WebApp slides down on phones or left on tablets) to reveal windows/tabs). Need to not show the Add tab button.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Per bug 1235869, we're going to disable the Android web runtime, so we won't fix this bug in it.

(This is part of a bulk resolution of bugs in the Firefox for Android::Web Apps component, from which I attempted to exclude bugs that are not specific to the runtime, but it's possible that I included one accidentally.  If so, I'm sorry, and please reopen the bug!)