766341 - Fix debug warnings in nsDocShell.cpp

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 634608 [details] [diff] [review]
Patch

>From: David Zbarsky <[e-mail]>
>
>diff --git a/docshell/base/nsDocShell.cpp b/docshell/base/nsDocShell.cpp
>--- a/docshell/base/nsDocShell.cpp
>+++ b/docshell/base/nsDocShell.cpp
>@@ -781,17 +781,17 @@ nsDocShell::nsDocShell():
>     if (gDocShellLeakLog)
>         PR_LOG(gDocShellLeakLog, PR_LOG_DEBUG, ("DOCSHELL %p created\n", this));
> #endif
> 
> #ifdef DEBUG
>   // We're counting the number of |nsDocShells| to help find leaks
>   ++gNumberOfDocShells;
>   if (!PR_GetEnv("MOZ_QUIET")) {
>-      printf("++DOCSHELL %p == %ld [id = %ld]\n", (void*) this,
>+      printf("++DOCSHELL %p == %ld [id = %llu]\n", (void*) this,
>              gNumberOfDocShells, mHistoryID);
>   }
> #endif
> }
> 
> nsDocShell::~nsDocShell()
> {
>     Destroy();
>@@ -810,17 +810,17 @@ nsDocShell::~nsDocShell()
>     if (gDocShellLeakLog)
>         PR_LOG(gDocShellLeakLog, PR_LOG_DEBUG, ("DOCSHELL %p destroyed\n", this));
> #endif
> 
> #ifdef DEBUG
>     // We're counting the number of |nsDocShells| to help find leaks
>     --gNumberOfDocShells;
>     if (!PR_GetEnv("MOZ_QUIET")) {
>-        printf("--DOCSHELL %p == %ld [id = %ld]\n", (void*) this,
>+        printf("--DOCSHELL %p == %ld [id = %llu]\n", (void*) this,
>                gNumberOfDocShells, mHistoryID);
>     }
> #endif
> 
>     if (mInPrivateBrowsing) {
>         DecreasePrivateDocShellCount();
>     }
> }

Comment 2

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e232778279a

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7e232778279a