Fix debug warnings in nsDocShell.cpp

RESOLVED FIXED in mozilla16

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 634608 [details] [diff] [review]
Patch
Attachment #634608 - Flags: review?(bugs)

Comment 1

5 years ago
Comment on attachment 634608 [details] [diff] [review]
Patch

>From: David Zbarsky <dzbarsky@gmail.com>
>
>diff --git a/docshell/base/nsDocShell.cpp b/docshell/base/nsDocShell.cpp
>--- a/docshell/base/nsDocShell.cpp
>+++ b/docshell/base/nsDocShell.cpp
>@@ -781,17 +781,17 @@ nsDocShell::nsDocShell():
>     if (gDocShellLeakLog)
>         PR_LOG(gDocShellLeakLog, PR_LOG_DEBUG, ("DOCSHELL %p created\n", this));
> #endif
> 
> #ifdef DEBUG
>   // We're counting the number of |nsDocShells| to help find leaks
>   ++gNumberOfDocShells;
>   if (!PR_GetEnv("MOZ_QUIET")) {
>-      printf("++DOCSHELL %p == %ld [id = %ld]\n", (void*) this,
>+      printf("++DOCSHELL %p == %ld [id = %llu]\n", (void*) this,
>              gNumberOfDocShells, mHistoryID);
>   }
> #endif
> }
> 
> nsDocShell::~nsDocShell()
> {
>     Destroy();
>@@ -810,17 +810,17 @@ nsDocShell::~nsDocShell()
>     if (gDocShellLeakLog)
>         PR_LOG(gDocShellLeakLog, PR_LOG_DEBUG, ("DOCSHELL %p destroyed\n", this));
> #endif
> 
> #ifdef DEBUG
>     // We're counting the number of |nsDocShells| to help find leaks
>     --gNumberOfDocShells;
>     if (!PR_GetEnv("MOZ_QUIET")) {
>-        printf("--DOCSHELL %p == %ld [id = %ld]\n", (void*) this,
>+        printf("--DOCSHELL %p == %ld [id = %llu]\n", (void*) this,
>                gNumberOfDocShells, mHistoryID);
>     }
> #endif
> 
>     if (mInPrivateBrowsing) {
>         DecreasePrivateDocShellCount();
>     }
> }
Attachment #634608 - Flags: review?(bugs) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e232778279a
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla16

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7e232778279a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.