Last Comment Bug 766341 - Fix debug warnings in nsDocShell.cpp
: Fix debug warnings in nsDocShell.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: David Zbarsky (:dzbarsky)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-19 15:03 PDT by David Zbarsky (:dzbarsky)
Modified: 2012-06-20 02:19 PDT (History)
2 users (show)
dzbarsky: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.30 KB, patch)
2012-06-19 15:03 PDT, David Zbarsky (:dzbarsky)
bugs: review+
Details | Diff | Review

Description David Zbarsky (:dzbarsky) 2012-06-19 15:03:39 PDT
Created attachment 634608 [details] [diff] [review]
Patch
Comment 1 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2012-06-19 16:08:45 PDT
Comment on attachment 634608 [details] [diff] [review]
Patch

>From: David Zbarsky <dzbarsky@gmail.com>
>
>diff --git a/docshell/base/nsDocShell.cpp b/docshell/base/nsDocShell.cpp
>--- a/docshell/base/nsDocShell.cpp
>+++ b/docshell/base/nsDocShell.cpp
>@@ -781,17 +781,17 @@ nsDocShell::nsDocShell():
>     if (gDocShellLeakLog)
>         PR_LOG(gDocShellLeakLog, PR_LOG_DEBUG, ("DOCSHELL %p created\n", this));
> #endif
> 
> #ifdef DEBUG
>   // We're counting the number of |nsDocShells| to help find leaks
>   ++gNumberOfDocShells;
>   if (!PR_GetEnv("MOZ_QUIET")) {
>-      printf("++DOCSHELL %p == %ld [id = %ld]\n", (void*) this,
>+      printf("++DOCSHELL %p == %ld [id = %llu]\n", (void*) this,
>              gNumberOfDocShells, mHistoryID);
>   }
> #endif
> }
> 
> nsDocShell::~nsDocShell()
> {
>     Destroy();
>@@ -810,17 +810,17 @@ nsDocShell::~nsDocShell()
>     if (gDocShellLeakLog)
>         PR_LOG(gDocShellLeakLog, PR_LOG_DEBUG, ("DOCSHELL %p destroyed\n", this));
> #endif
> 
> #ifdef DEBUG
>     // We're counting the number of |nsDocShells| to help find leaks
>     --gNumberOfDocShells;
>     if (!PR_GetEnv("MOZ_QUIET")) {
>-        printf("--DOCSHELL %p == %ld [id = %ld]\n", (void*) this,
>+        printf("--DOCSHELL %p == %ld [id = %llu]\n", (void*) this,
>                gNumberOfDocShells, mHistoryID);
>     }
> #endif
> 
>     if (mInPrivateBrowsing) {
>         DecreasePrivateDocShellCount();
>     }
> }
Comment 2 David Zbarsky (:dzbarsky) 2012-06-19 17:18:11 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e232778279a
Comment 3 Ed Morley [:emorley] 2012-06-20 02:19:02 PDT
https://hg.mozilla.org/mozilla-central/rev/7e232778279a

Note You need to log in before you can comment on or make changes to this bug.