The default bug view has changed. See this FAQ.

ClearOnShutdown_Internal::ShutdownObserver needs a virtual destructor

RESOLVED FIXED in mozilla16

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
ClearOnShutdown.cpp
In file included from /Users/ehsanakhgari/moz/mozilla-central/xpcom/base/ClearOnShutdown.cpp:8:
../../dist/include/mozilla/ClearOnShutdown.h:89:5: warning: delete called on 'mozilla::ClearOnShutdown_Internal::ShutdownObserver' that is abstract but has non-virtual destructor
      [-Wdelete-non-virtual-dtor]
    delete observer;
    ^
1 warning generated.
(Assignee)

Comment 1

5 years ago
Created attachment 634621 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #634621 - Flags: review?(benjamin)
Attachment #634621 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7dc563a8f43
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/d7dc563a8f43
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.