Closed Bug 766349 Opened 9 years ago Closed 9 years ago

ClearOnShutdown_Internal::ShutdownObserver needs a virtual destructor

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 file)

ClearOnShutdown.cpp
In file included from /Users/ehsanakhgari/moz/mozilla-central/xpcom/base/ClearOnShutdown.cpp:8:
../../dist/include/mozilla/ClearOnShutdown.h:89:5: warning: delete called on 'mozilla::ClearOnShutdown_Internal::ShutdownObserver' that is abstract but has non-virtual destructor
      [-Wdelete-non-virtual-dtor]
    delete observer;
    ^
1 warning generated.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #634621 - Flags: review?(benjamin)
Attachment #634621 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/d7dc563a8f43
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.