Last Comment Bug 766349 - ClearOnShutdown_Internal::ShutdownObserver needs a virtual destructor
: ClearOnShutdown_Internal::ShutdownObserver needs a virtual destructor
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: unspecified
: x86 Mac OS X
-- normal (vote)
: mozilla16
Assigned To: :Ehsan Akhgari
: Nathan Froyd [:froydnj]
Depends on:
  Show dependency treegraph
Reported: 2012-06-19 15:20 PDT by :Ehsan Akhgari
Modified: 2012-06-23 05:47 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (v1) (606 bytes, patch)
2012-06-19 15:24 PDT, :Ehsan Akhgari
benjamin: review+
Details | Diff | Splinter Review

Description User image :Ehsan Akhgari 2012-06-19 15:20:50 PDT
In file included from /Users/ehsanakhgari/moz/mozilla-central/xpcom/base/ClearOnShutdown.cpp:8:
../../dist/include/mozilla/ClearOnShutdown.h:89:5: warning: delete called on 'mozilla::ClearOnShutdown_Internal::ShutdownObserver' that is abstract but has non-virtual destructor
    delete observer;
1 warning generated.
Comment 1 User image :Ehsan Akhgari 2012-06-19 15:24:26 PDT
Created attachment 634621 [details] [diff] [review]
Patch (v1)
Comment 3 User image Ryan VanderMeulen [:RyanVM] 2012-06-23 05:47:03 PDT

Note You need to log in before you can comment on or make changes to this bug.