766392 - Persist the reference to marketplace on about:apps even when apps are installed on about:apps

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P2)

Description

[Jason Smith [:jsmith]]

Right now, the reference to marketplace is only shown if there are no apps installed. We should persist this link permanently on the about:apps page to allow a user to easily get to the marketplace when viewing their apps they have installed.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: WIP Screenshot

I think this page needs a small redesign to better match our other about pages anyway. Something kinda like this. Note we have that exact same icon in the upper right on about:addons, except there it links to AMO. Here it can link to the marketplace. And we should probably at the same time fix this disconnect between addons and apps using the same icon?

In both cases, its not obvious its a link. So we need to think of/design something a bit smarter. Add an arrow, or make it look more like a clickable button?

Comment 2

[Jason Smith [:jsmith]]

k9o nomination - important implementation for fennec native app management

Comment 3

[Wesley Johnston (:wesj)]

Attachment: WIP Patch

Looking at this again. I really want to slip things off into a base style, so that's what I'm doing.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

I want this for any previews. This is the simplest way to get to it I think. I'll post some screenshots....

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Screenshot with an app

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Screenshot with no apps

No apps. This text might be too small? We can try this and increase it if it is.

Comment 7

[Jason Smith [:jsmith]]

Much cleaner look and feel overall. I like it.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 649497 [details] [diff] [review]
Patch

This gets us much closer to the other about pages. We can tweak more in followups.

Comment 9

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1bb507f20428

Comment 11

[Aaron Train [:aaronmt]]

Verified on mozilla-inbound (17)

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1bb507f20428

Comment 13

[Wesley Johnston (:wesj)]

Comment on attachment 649497 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Original about:apps impelementation
User impact if declined: about:apps doesn't look like our other about pages, lacks a persistent reference to the store.
Testing completed (on m-c, etc.): landed on mc this 8/1
Risk to taking this patch (and alternatives if risky): Very low risk. Mostly visual clean up
String or UUID changes made by this patch: None.

Comment 14

[Aaron Train [:aaronmt]]

Checkin for Aurora, right?

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9223cf558eea