Last Comment Bug 766413 - Crash with contentReadOnly, forwardDelete
: Crash with contentReadOnly, forwardDelete
Status: RESOLVED FIXED
: crash, testcase
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- critical (vote)
: mozilla16
Assigned To: Aryeh Gregor (:ayg) (away until October 25)
:
:
Mentors:
Depends on:
Blocks: 336383 762183
  Show dependency treegraph
 
Reported: 2012-06-19 18:01 PDT by Jesse Ruderman
Modified: 2012-06-21 04:07 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (crashes Firefox when loaded) (995 bytes, text/html)
2012-06-19 18:01 PDT, Jesse Ruderman
no flags Details
stack trace (13.91 KB, text/plain)
2012-06-19 18:02 PDT, Jesse Ruderman
no flags Details
Patch v1 (3.27 KB, patch)
2012-06-20 01:05 PDT, Aryeh Gregor (:ayg) (away until October 25)
ehsan: review+
Details | Diff | Splinter Review

Description Jesse Ruderman 2012-06-19 18:01:32 PDT
Created attachment 634688 [details]
testcase (crashes Firefox when loaded)

Messy testcase.  I guess some state is not visible to serializeDOMAsScript :/
Comment 1 Jesse Ruderman 2012-06-19 18:02:32 PDT
Created attachment 634689 [details]
stack trace
Comment 2 Jesse Ruderman 2012-06-19 18:04:50 PDT
bp-2d8d05cf-c567-4651-ba1c-46b302120620
Comment 3 :Ehsan Akhgari 2012-06-19 18:40:28 PDT
Aryeh, can you please take a look?
Comment 4 Aryeh Gregor (:ayg) (away until October 25) 2012-06-20 00:57:08 PDT
This was bug 762183 part 4.  It added a while loop to change selectedNode's value, but didn't account for the fact that it might set it to null.  Just need a null check here.
Comment 5 Aryeh Gregor (:ayg) (away until October 25) 2012-06-20 01:05:19 PDT
Created attachment 634809 [details] [diff] [review]
Patch v1

https://tbpl.mozilla.org/?tree=Try&rev=dc65bbdb8a0d
Comment 6 Scoobidiver (away) 2012-06-20 01:19:41 PDT
On Windows: bp-591d4a60-3df4-4f94-8c9f-12fb72120620.
Comment 8 Ed Morley [:emorley] 2012-06-21 04:07:52 PDT
https://hg.mozilla.org/mozilla-central/rev/60a0cc699002

Note You need to log in before you can comment on or make changes to this bug.