766528 - Allow customizing the time tracking field labels

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Pami Ketolainen]

Attachment: v1

The field labels on show bug page can be customized by overriding the field description in "hook/global/field-descs-end.none.tmpl"

However, the time tracking fields do not use the common bug/field* templates and so they do not reflect the changes made in that template hook.

This prevents for example changing the "hours" to something else.

Attached is a patch to change the templates so that field-descs values are also used for the time tracking fields. It simply replaces the hard coded labels with '[% INCLUDE "bug/field-label.html.tmpl" ...'

Comment 1

[Frédéric Buclin]

Comment on attachment 634859 [details] [diff] [review]
v1

>+      [% INCLUDE "bug/field-label.html.tmpl"
>+        field = bug_fields.estimated_time
>+      %]

This looks good, but you also have to pass editable = 1 to all these directives as all users who can see these fields can also edit them.

Comment 2

[Pami Ketolainen]

(In reply to Frédéric Buclin from comment #1)
> Comment on attachment 634859 [details] [diff] [review]
> v1
> 
> >+      [% INCLUDE "bug/field-label.html.tmpl"
> >+        field = bug_fields.estimated_time
> >+      %]
> 
> This looks good, but you also have to pass editable = 1 to all these
> directives as all users who can see these fields can also edit them.

Ok, I wasn't exactly sure if editable is needed. In field-label.html.tmpl it only seems to affect whether the description is wrapped in <label> tag.

Should they also have some accesskey?

Comment 3

[Pami Ketolainen]

Attachment: v2

Added the editable = 1

Leaving out the accesskey, as it's probably a different story to decide whether those fields need access key, and what would be the appropriate one for each.

Comment 4

[Frédéric Buclin]

Comment on attachment 634904 [details] [diff] [review]
v2

>=== modified file 'template/en/default/bug/edit.html.tmpl'

>-      <th>
>-        %Complete
>-      </th>

This can be replaced by bug_fields.percentage_complete too. Otherwise looks good and works fine. r=LpSolit

Comment 5

[Frédéric Buclin]

Thanks for your contribution. :)

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/bug/edit.html.tmpl
modified template/en/default/list/edit-multiple.html.tmpl
Committed revision 8272.