Closed
Bug 766535
Opened 13 years ago
Closed 13 years ago
[devtb] this.DeveloperToolbar is undefined when starting Firefox with toolbar previously visible
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: paul, Unassigned)
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 3 obsolete files)
|
1.20 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•13 years ago
|
||
|
|
Reporter | |
Comment 2•13 years ago
|
||
|
|
Reporter | |
Updated•13 years ago
|
Attachment #634872 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•13 years ago
|
Attachment #634875 -
Flags: review?(gavin.sharp)
|
||
Updated•13 years ago
|
Attachment #634872 -
Flags: review+
|
|
||
Updated•13 years ago
|
Attachment #634872 -
Flags: review+
|
|
||
Comment 3•13 years ago
|
||
This will cause the DeveloperToolbar to be instantiated every startup - move the DeveloperToolbar reference after the pref check.
|
||
Comment 4•13 years ago
|
||
Comment on attachment 634875 [details] [diff] [review]
v1
>+ if (window.DeveloperToolbar &&
Why would DeveloperToolbar be null/undefined?
|
|
Reporter | |
Comment 5•13 years ago
|
||
|
|
Reporter | |
Updated•13 years ago
|
Attachment #634875 -
Attachment is obsolete: true
Attachment #634875 -
Flags: review?(gavin.sharp)
|
|
Reporter | |
Comment 6•13 years ago
|
||
Comment on attachment 634894 [details] [diff] [review]
v1.1
testing window.DeveloperToolbar is useless.
Attachment #634894 -
Flags: review?(dao)
|
|
||
Comment 7•13 years ago
|
||
Comment on attachment 634894 [details] [diff] [review]
v1.1
remove "window.", it's redundant
Attachment #634894 -
Flags: review?(dao) → review+
|
|
Reporter | |
Comment 8•13 years ago
|
||
|
|
Reporter | |
Updated•13 years ago
|
Attachment #634894 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•13 years ago
|
Whiteboard: [land-in-fx-team]
|
|
Reporter | |
Comment 9•13 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
||
Comment 10•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•