[devtb] this.DeveloperToolbar is undefined when starting Firefox with toolbar previously visible

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: paul, Unassigned)

Tracking

Trunk
Firefox 16
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
(Reporter)

Comment 1

5 years ago
Created attachment 634872 [details] [diff] [review]
s/this/window/
(Reporter)

Comment 2

5 years ago
Created attachment 634875 [details] [diff] [review]
v1
(Reporter)

Updated

5 years ago
Attachment #634872 - Attachment is obsolete: true
(Reporter)

Updated

5 years ago
Attachment #634875 - Flags: review?(gavin.sharp)

Updated

5 years ago
Attachment #634872 - Flags: review+

Updated

5 years ago
Attachment #634872 - Flags: review+

Comment 3

5 years ago
This will cause the DeveloperToolbar to be instantiated every startup - move the DeveloperToolbar reference after the pref check.
Comment on attachment 634875 [details] [diff] [review]
v1

>+      if (window.DeveloperToolbar &&

Why would DeveloperToolbar be null/undefined?
(Reporter)

Comment 5

5 years ago
Created attachment 634894 [details] [diff] [review]
v1.1
(Reporter)

Updated

5 years ago
Attachment #634875 - Attachment is obsolete: true
Attachment #634875 - Flags: review?(gavin.sharp)
(Reporter)

Comment 6

5 years ago
Comment on attachment 634894 [details] [diff] [review]
v1.1

testing window.DeveloperToolbar is useless.
Attachment #634894 - Flags: review?(dao)
Comment on attachment 634894 [details] [diff] [review]
v1.1

remove "window.", it's redundant
Attachment #634894 - Flags: review?(dao) → review+
(Reporter)

Comment 8

5 years ago
Created attachment 634900 [details] [diff] [review]
v1.1 - to land
(Reporter)

Updated

5 years ago
Attachment #634894 - Attachment is obsolete: true
(Reporter)

Updated

5 years ago
Whiteboard: [land-in-fx-team]
(Reporter)

Comment 9

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/5a81009ec864
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5a81009ec864
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
You need to log in before you can comment on or make changes to this bug.