766557 - The update dialog window has LTR direction on RTL builds

Status: NEW

(Firefox :: General, defect)

Description

[Itiel]

Attachment: Picture of the RTL issue.png

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0.1
Build ID: 20120614114901

Steps to reproduce:

1. Updated an addon.
2. When it asked to restart firefox, I confirmed.
3. A "Firefox will try to restore your tabs and Windows when it restarts" window (with hebrew text) appeared.


Actual results:

The text in the window was LTR despite the fact that my firefox is RTL version (hebrew).
A picture is attached.


Expected results:

The text should appear as RTL.

If I'm not mistaken, it didn't happen in previous versions.

Comment 1

[Itiel]

...

Comment 2

[Tomer Cohen :tomer]

Probably a regression.

Comment 3

[Simon Montagu :smontagu]

This looks like a consequence of using auto-direction in message boxes (bug 652550)

Comment 4

[Simon Montagu :smontagu]

This is the same issue as bug 753664. See especially bug 753664 comment 2 and bug 753664 comment 4.

Comment 5

[Itiel]

Still happening in Firefox 45.0.2..

Comment 6

[Itiel]

Attachment: Screenshot when updating Firefox.png

About the same issue applies in this attached screenshot, when updating Firefox to a newer version (in this case from 45 to 46)

Comment 7

[Tomer Cohen :tomer]

(In reply to Simon Montagu :smontagu from comment #4)
> This is the same issue as bug 753664. See especially bug 753664 comment 2
> and bug 753664 comment 4.

If there is no solution so far, we can in the meantime prepend RLM to these strings as a workaround to this problem.

Comment 8

[Itiel]

Hmm. Fun fact- this string doesn't appear anymore in the translations.
But appending RLM to such strings in message boxes seems like a good idea to me.

Comment 9

[Tomer Cohen :tomer]

I prefer to prepend some control characters only as last option, because it is not easy to distinguish such strings from regular strings, and this bug will reappear every time these strings changes or there is a new message box.

Comment 10

[Itiel]

Prepending RLM to the problematic string's translation fixes the issue.
https://hg.mozilla.org/releases/l10n/mozilla-aurora/he/rev/bb1405e4819c

Comment 11

[Tomer Cohen :tomer]

(In reply to ItielMaN from comment #10)
> Prepending RLM to the problematic string's translation fixes the issue.
It is a workaround, not a solution.

https://transvision.mozfr.org/string/?entity=browser/chrome/browser/shellservice.properties:setDefaultBrowserMessage&repo=aurora

Comment 12

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Update_affecteds