76657 - ViewSource protocol handler must use nsIRequest::LOAD_FROM_CACHE

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Chak Nanga]

In version 1.260 of nsDocShell we had:

// "View source" always wants VALIDATE_NEVER.                               

if ( mViewMode == viewSource ) {
       loadFlags |= nsIRequest::VALIDATE_NEVER;
}
} else { 
...
}

With the view-source: changes to nsDocShell.cpp we no longer have the mViewMode. 
So this code moved to nsViewSourceChannel.cpp

However, in 1.261 the above code became:

// "View source" always wants the currently cached content.
if ( mViewMode == viewSource ) { 
   loadFlags |= nsIRequest::LOAD_FROM_CACHE;
}
else {
....
}

When the viewsource changes were checked in (as version 1.262 the 
"nsIRequest::LOAD_FROM_CACHE" never got into nsViewSourceChannel.cpp).

nsViewSourceChannel.cpp must be updated to or with the 
"nsIRequest::LOAD_FROM_CACHE" in SetLoadFlags().

Comment 1

[Chak Nanga]

Attachment: Patch to use LOAD_FROM_CACHE flag

Comment 2

[Judson Valeski]

r=valeski.

Comment 3

[Brendan Eich [:brendan]]

sr=[e-mail].  I think we want this in 0.9, but I'll let blizzard or
asa give that a= so as to get some drivers peer review.

/be

Comment 4

[Asa Dotzler [:asa]]

a=[e-mail] for checkin to 0.9

Comment 5

[Chak Nanga]

Fix is in.