766654 - Pasting a URL into download manager to start a download does not work with the new download panel

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Matt Brubeck (:mbrubeck)]

In the old download manager, pasting a URL causes Firefox to download a URL.  This shortcut is useful because it's the one of the only ways to make Firefox start a download immediately rather than loading and viewing the URL.  This is no longer possible in the new downloads panel UI.

Comment 1

[Marco Bonardo [:mak]]

loss of functionality

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: WIP Patch 1

Checkpointing work here for the night. I still have a few focus issues to work out, but this basically works.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Here's my first run at this.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 680158 [details] [diff] [review]
Patch v1

Review of attachment 680158 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/downloads/content/downloads.js
@@ +308,5 @@
> +#else
> +                  aEvent.ctrlKey;
> +#endif
> +
> +    if (pasting) {

invert this and early return, so less indentation.

@@ +330,5 @@
> +        if (!url) {
> +          return;
> +        }
> +
> +        let uri = Services.io.newURI(url, null, null);

nit: lots of empty space above, maybe compact code a bit

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2 (r+'d by mak)

Thanks for the r+! Requested changes made.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Landed on mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/242334181a9d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/242334181a9d

Comment 8

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly - pasting a URL in the downloads panel starts the download.

Verified on Ubuntu 12.10, Mac OS X 10.7 and Windows 7:
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20121203 Firefox/20.0 Build ID: 20121203030801
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:20.0) Gecko/20121203 Firefox/20.0 Build ID: 20121203030801
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20121202 Firefox/20.0 Build ID: 20121202030723