Pasting a URL into download manager to start a download does not work with the new download panel

VERIFIED FIXED in Firefox 19

Status

()

Firefox
Downloads Panel
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: mbrubeck, Assigned: mconley)

Tracking

({regression, ux-efficiency})

16 Branch
Firefox 19
regression, ux-efficiency
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
In the old download manager, pasting a URL causes Firefox to download a URL.  This shortcut is useful because it's the one of the only ways to make Firefox start a download immediately rather than loading and viewing the URL.  This is no longer possible in the new downloads panel UI.
loss of functionality
Blocks: 747422
Assignee: nobody → mconley
Created attachment 679520 [details] [diff] [review]
WIP Patch 1

Checkpointing work here for the night. I still have a few focus issues to work out, but this basically works.
Created attachment 680158 [details] [diff] [review]
Patch v1

Here's my first run at this.
Attachment #679520 - Attachment is obsolete: true
Attachment #680158 - Flags: review?(mak77)
Comment on attachment 680158 [details] [diff] [review]
Patch v1

Review of attachment 680158 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/downloads/content/downloads.js
@@ +308,5 @@
> +#else
> +                  aEvent.ctrlKey;
> +#endif
> +
> +    if (pasting) {

invert this and early return, so less indentation.

@@ +330,5 @@
> +        if (!url) {
> +          return;
> +        }
> +
> +        let uri = Services.io.newURI(url, null, null);

nit: lots of empty space above, maybe compact code a bit
Attachment #680158 - Flags: review?(mak77) → review+
Created attachment 681148 [details] [diff] [review]
Patch v2 (r+'d by mak)

Thanks for the r+! Requested changes made.
Attachment #680158 - Attachment is obsolete: true
Landed on mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/242334181a9d
https://hg.mozilla.org/mozilla-central/rev/242334181a9d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19

Comment 8

5 years ago
Verified as fixed on the latest Nightly - pasting a URL in the downloads panel starts the download.

Verified on Ubuntu 12.10, Mac OS X 10.7 and Windows 7:
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20121203 Firefox/20.0 Build ID: 20121203030801
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:20.0) Gecko/20121203 Firefox/20.0 Build ID: 20121203030801
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20121202 Firefox/20.0 Build ID: 20121202030723
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.