766664 - make double-including package-name.mk not break things

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Currently package-name.mk gets double-included in a few places, which breaks using MOZ_PKG_SPECIAL.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: make double-including package-name.mk not break things

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 634995 [details] [diff] [review]
make double-including package-name.mk not break things

Review of attachment 634995 [details] [diff] [review]:
-----------------------------------------------------------------

Is that enough for the triple inclusion in the test package name?

Comment 3

[(not currently active) Ted Mielczarek]

I just tested locally and this fixes the test package name issue.

http://hg.mozilla.org/integration/mozilla-inbound/rev/8f91afcac737

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8f91afcac737

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 634995 [details] [diff] [review]
make double-including package-name.mk not break things

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: packaging ARMv6 doesn't break
Testing completed (on m-c, etc.): landed on m-c when it was Fx16
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 6

[(not currently active) Ted Mielczarek]

This patch is very low-risk. It's simply a correctness fix in the build system that happened to be necessary to make another patch work properly.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 634995 [details] [diff] [review]
make double-including package-name.mk not break things

build system fix, approving.