make double-including package-name.mk not break things

RESOLVED FIXED in mozilla16

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Currently package-name.mk gets double-included in a few places, which breaks using MOZ_PKG_SPECIAL.
(Assignee)

Comment 1

5 years ago
Created attachment 634995 [details] [diff] [review]
make double-including package-name.mk not break things
Attachment #634995 - Flags: review?(mh+mozilla)
Comment on attachment 634995 [details] [diff] [review]
make double-including package-name.mk not break things

Review of attachment 634995 [details] [diff] [review]:
-----------------------------------------------------------------

Is that enough for the triple inclusion in the test package name?
Attachment #634995 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

5 years ago
Blocks: 723946
(Assignee)

Comment 3

5 years ago
I just tested locally and this fixes the test package name issue.

http://hg.mozilla.org/integration/mozilla-inbound/rev/8f91afcac737
Status: NEW → ASSIGNED

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/8f91afcac737
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Comment on attachment 634995 [details] [diff] [review]
make double-including package-name.mk not break things

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: packaging ARMv6 doesn't break
Testing completed (on m-c, etc.): landed on m-c when it was Fx16
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:
Attachment #634995 - Flags: approval-mozilla-beta?
(Assignee)

Comment 6

5 years ago
This patch is very low-risk. It's simply a correctness fix in the build system that happened to be necessary to make another patch work properly.
Comment on attachment 634995 [details] [diff] [review]
make double-including package-name.mk not break things

build system fix, approving.
Attachment #634995 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.