Last Comment Bug 766683 - Export nsNSSShutdown.h from PSM so that other modules can use it
: Export nsNSSShutdown.h from PSM so that other modules can use it
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Security: PSM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Brian Smith (:briansmith, :bsmith, use NEEDINFO?)
:
: David Keeler [:keeler] (use needinfo?)
Mentors:
Depends on:
Blocks: 753238
  Show dependency treegraph
 
Reported: 2012-06-20 12:58 PDT by Brian Smith (:briansmith, :bsmith, use NEEDINFO?)
Modified: 2012-06-28 19:09 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Export nsNSSShutdown from PSM (863 bytes, patch)
2012-06-20 12:58 PDT, Brian Smith (:briansmith, :bsmith, use NEEDINFO?)
kaie: review+
Details | Diff | Splinter Review

Description Brian Smith (:briansmith, :bsmith, use NEEDINFO?) 2012-06-20 12:58:45 PDT
Created attachment 635022 [details] [diff] [review]
Export nsNSSShutdown from PSM

The new Identity service (for Browser ID / Mozilla Persona) and the Sync J-PAKE component (nsSyncJPAKE) need to use nsNSSShutdownObject to handle shutdown properly. This patch just exports the nsNSSShutdown.h header from PSM so that other modules can use it. Luckily, nsNSSShutdown.h doesn't have any dependencies on other PSM or NSS stuff.

We are hoping to land the Identity stuff very soon (within a week, I believe).
Comment 1 Kai Engert (:kaie) 2012-06-28 11:41:24 PDT
In the past, there was the rule that direct link dependencies between XPCOM modules, circumventing IDL, wasn't allowed.

I just asked on IRC and got an answer that nowadays it is allowed. Based on that:

r=kaie
Comment 2 Brian Smith (:briansmith, :bsmith, use NEEDINFO?) 2012-06-28 15:34:42 PDT
https://hg.mozilla.org/mozilla-central/rev/e59db72b33d5

Note You need to log in before you can comment on or make changes to this bug.