The default bug view has changed. See this FAQ.

Can't use both REPLACE_HISTORY and BYPASS_CACHE flags when calling nsIWebNavigation::loadURI()

RESOLVED FIXED in mozilla16

Status

()

Core
Document Navigation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

unspecified
mozilla16
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
<bz> but in any case, the upshot is that there is no valid docshell loadtype that has both flags
<bz> and docshell uses integer loadtypes instead of flag bits
<bz> so it's all kinda broken
<bz> any time you want to do a new flag combination, you have to explicitly allow it...
<bz> And in particular, nsDocShell::DoChannelLoad does a switch, not a bit check
(Assignee)

Comment 1

5 years ago
Created attachment 635127 [details] [diff] [review]
Add LOAD_REPLACE_BYPASS_CACHE load type

This patch works for me, but I had to guess on a few things:
- whether this should be prefixed with LOAD_NORMAL or just LOAD
- what nsIDOMPerformanceNavigation type this should be considered as

This change is for the "Request Desktop Site" feature on mobile (bug 766406). If changing from a mobile->desktop version of a page, we want to make sure we aren't showing the cached mobile page, and we also don't want the same URL to be in the history twice.
Assignee: nobody → bnicholson
Attachment #635127 - Flags: review?(bzbarsky)
Comment on attachment 635127 [details] [diff] [review]
Add LOAD_REPLACE_BYPASS_CACHE load type

r=me
Attachment #635127 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

5 years ago
Blocks: 766406
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/48e15675e290
(Assignee)

Comment 4

5 years ago
Created attachment 635457 [details] [diff] [review]
Follow-up to add missing break

http://hg.mozilla.org/integration/mozilla-inbound/rev/93f5a6a9474a
https://hg.mozilla.org/mozilla-central/rev/48e15675e290
https://hg.mozilla.org/mozilla-central/rev/93f5a6a9474a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.