766757 - Can't use both REPLACE_HISTORY and BYPASS_CACHE flags when calling nsIWebNavigation::loadURI()

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Brian Nicholson (:bnicholson)]

<bz> but in any case, the upshot is that there is no valid docshell loadtype that has both flags
<bz> and docshell uses integer loadtypes instead of flag bits
<bz> so it's all kinda broken
<bz> any time you want to do a new flag combination, you have to explicitly allow it...
<bz> And in particular, nsDocShell::DoChannelLoad does a switch, not a bit check

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Add LOAD_REPLACE_BYPASS_CACHE load type

This patch works for me, but I had to guess on a few things:
- whether this should be prefixed with LOAD_NORMAL or just LOAD
- what nsIDOMPerformanceNavigation type this should be considered as

This change is for the "Request Desktop Site" feature on mobile (bug 766406). If changing from a mobile->desktop version of a page, we want to make sure we aren't showing the cached mobile page, and we also don't want the same URL to be in the history twice.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 635127 [details] [diff] [review]
Add LOAD_REPLACE_BYPASS_CACHE load type

r=me

Comment 3

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/48e15675e290

Comment 4

[Brian Nicholson (:bnicholson)]

Attachment: Follow-up to add missing break

http://hg.mozilla.org/integration/mozilla-inbound/rev/93f5a6a9474a

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/48e15675e290
https://hg.mozilla.org/mozilla-central/rev/93f5a6a9474a