Last Comment Bug 766798 - Stop throwing NAMESPACE_ERR from querySelector(All)
: Stop throwing NAMESPACE_ERR from querySelector(All)
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla16
Assigned To: Boris Zbarsky [:bz]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-20 17:25 PDT by Boris Zbarsky [:bz]
Modified: 2012-06-23 05:45 PDT (History)
1 user (show)
bzbarsky: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Throw SYNTAX_ERR, not NAMESPACE_ERR, from querySelector(All) on unknown namespaces. (4.55 KB, patch)
2012-06-20 21:10 PDT, Boris Zbarsky [:bz]
no flags Details | Diff | Splinter Review
Throw SYNTAX_ERR, not NAMESPACE_ERR, from querySelector(All) on unknown namespaces. (6.00 KB, patch)
2012-06-21 08:29 PDT, Boris Zbarsky [:bz]
dbaron: review+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] 2012-06-20 17:25:32 PDT
Spec change says this should now be a SYNTAX_ERR.  We can rip out some complexity.
Comment 1 Boris Zbarsky [:bz] 2012-06-20 21:10:48 PDT
Created attachment 635181 [details] [diff] [review]
Throw SYNTAX_ERR, not NAMESPACE_ERR, from querySelector(All) on unknown namespaces.
Comment 2 Boris Zbarsky [:bz] 2012-06-21 08:29:56 PDT
Created attachment 635331 [details] [diff] [review]
Throw SYNTAX_ERR, not NAMESPACE_ERR, from querySelector(All) on unknown namespaces.
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-06-21 11:31:59 PDT
Comment on attachment 635331 [details] [diff] [review]
Throw SYNTAX_ERR, not NAMESPACE_ERR, from querySelector(All) on unknown namespaces.

r=dbaron
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-06-23 05:45:31 PDT
https://hg.mozilla.org/mozilla-central/rev/39fe6a5626dd

Note You need to log in before you can comment on or make changes to this bug.