Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Clear dead wood from Bindings

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 635165 [details] [diff] [review]
patch

This patch cleans up Bindings.

- It removes the unnecessary |cx| arg from Bindings() and transfer().

- It removes clone() and lastArgument(), because they are dead.

- It removes makeImmutable().  It wasn't dead, but it only contains
  assertions and the comment above its declaration was completely 
  misleading, so it didn't seem worth salvaging.
Attachment #635165 - Flags: review?(luke)

Comment 1

5 years ago
Comment on attachment 635165 [details] [diff] [review]
patch

Right on.
Attachment #635165 - Flags: review?(luke) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfa21a56f646

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/bfa21a56f646
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.