Last Comment Bug 766870 - B2G RIL: Simplify the nsIRILDataCallback.dataCallStateChanged interface
: B2G RIL: Simplify the nsIRILDataCallback.dataCallStateChanged interface
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla16
Assigned To: Kan-Ru Chen [:kanru] (UTC+8)
:
Mentors:
Depends on:
Blocks: b2g-ril
  Show dependency treegraph
 
Reported: 2012-06-21 00:01 PDT by Kan-Ru Chen [:kanru] (UTC+8)
Modified: 2012-06-22 09:16 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Simplify nsIRILDataCallback.dataCallStateChanged interface (6.72 KB, patch)
2012-06-21 00:09 PDT, Kan-Ru Chen [:kanru] (UTC+8)
philipp: review+
Details | Diff | Splinter Review

Description Kan-Ru Chen [:kanru] (UTC+8) 2012-06-21 00:01:28 PDT
Pass nsIRILDataCallInfo to it and make it consistent with the nsIRILDataCallback.receiveDataCallList interface.
Comment 1 Kan-Ru Chen [:kanru] (UTC+8) 2012-06-21 00:09:49 PDT
Created attachment 635204 [details] [diff] [review]
Simplify nsIRILDataCallback.dataCallStateChanged interface
Comment 2 Philipp von Weitershausen [:philikon] 2012-06-21 12:15:02 PDT
Comment on attachment 635204 [details] [diff] [review]
Simplify nsIRILDataCallback.dataCallStateChanged interface

Review of attachment 635204 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Comment 3 Kan-Ru Chen [:kanru] (UTC+8) 2012-06-21 22:56:00 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d5e44898e8f
Comment 4 Ed Morley [:emorley] 2012-06-22 09:16:49 PDT
https://hg.mozilla.org/mozilla-central/rev/8d5e44898e8f

Note You need to log in before you can comment on or make changes to this bug.