766875 - Reddit Enhancement Suite add-on creates zombie compartments

Status: RESOLVED WORKSFORME

(WebExtensions :: General, defect)

Description

[Nigel Babu [:nigelb]]

The Reddit Enhancement Suite downloadable from http://redditenhancementsuite.com/ creates a lot of zombie compartments and causes firefox to leak a lot of memory.  I went up to 1.8 GB of RAM with only 6 tabs.  Further investigation found the compartments.

Comment 1

[Danial Horton]

Was this under 13/14?

can you test under nightly as well?

Comment 2

[Nigel Babu [:nigelb]]

This was on Aurora.  I'll run this on Nightly for a week or so and report back.

Comment 3

[Loic]

Check https://developer.mozilla.org/en/Zombie_Compartments#Zombie_compartments for investigation details too (memory logs from about:memory and about:compartments).

Comment 4

[Kris Maglione [:kmag]]

I can't reproduce this on 13 or 15. I don't get any zombie compartments. It does create 76 new compartments, but they're all legitimate Jetpack modules. And I don't have any memory issues. After browsing several Reddit pages and closing them, I'm back to my base memory footprint. I also don't see anything especially suspicious in the code that I would expect to cause memory leaks. They are using Jetpack 1.6.1, though. It would be nice if they upgraded to 1.7.

Comment 5

[Nicholas Nethercote [inactive]]

A commenter on my blog said that RES leaked so I also tried to reproduce (with a version prior to FF15) and I couldn't, even after logging in to Reddit.

Nigel, can you give detailed steps to reproduce?


> They are using Jetpack 1.6.1, though. It would be nice if they
> upgraded to 1.7.

We're up to 1.7 now?  Does it have big improvements over 1.6.1?  We were urging people to update to 1.6.1 only very recently, IIRC...

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

The SDK is updated with a similar frequency as Firefox, so I would change the messaging to "the latest stable version". I know that there are still leaks being found and fixed in the SDK, so it's good to encourage developers to keep up.

Comment 7

[Steve Sobel]

Hi, author of RES here...

I can't seem to figure out what in my code might cause these zombie compartments - and they only happen for what seems to be a very small subset of people (but for those people, the effect is really, really bad)....

Have you tested RES with all other addons disabled to ensure it's not some combination of two addons that's keeping Firefox holding reference to something that ends up causing the zombie compartments? That, I think, would go a decent way toward identifying the issue.

RES is almost entirely an injected content script, so I'm not sure what it could be doing to cause this on its own (not saying it's impossible, of course...)

Comment 8

[Nigel Babu [:nigelb]]

Here's the frustrating bit - I can't reproduce this anymore.  I uninstalled the add-on and re-installed and have been using it for a few days now and this time I can't reproduce the bug, whatever I do.  Happy to have this bug closed as resolved and file a new bug/reopen in case this crops up again with actual debugging information.

Comment 9

[Kris Maglione [:kmag]]

It's possible that you were using an older version of the add-on. Old versions of Jetpack created zombie compartments for every page that a page mod was used on.

Comment 10

[Nicholas Nethercote [inactive]]

(In reply to Kris Maglione [:kmag] from comment #9)
> It's possible that you were using an older version of the add-on. Old
> versions of Jetpack created zombie compartments for every page that a page
> mod was used on.

Mmm, that sounds like the most likely cause to me.