Closed Bug 766891 Opened 10 years ago Closed 10 years ago

B2G RIL: nsIRadioInterfaceLayer.DATACALL_STATE_* values is not synced with ril_consts.js

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: kanru, Assigned: kanru)

References

Details

Attachments

(1 file, 2 obsolete files)

Remove nsIRadioInterfaceLayer.DATACALL_STATE_*
2.52 KB, patch
Details | Diff | Splinter Review 
And the GECKO_NETWORK_STATE_* values in ril_consts.js is synced with nsINetworkManager.NETWORK_STATE_*

Should we conciliate this to one place?
Assignee: nobody → kchen
Attachment #635222 - Flags: review?(philipp)
Comment on attachment 635222 [details] [diff] [review]
Sync nsIRadioInterfaceLayer.DATACALL_STATE_*  with ril_consts.js

Review of attachment 635222 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!
Attachment #635222 - Flags: review?(philipp) → review+
(In reply to Philipp von Weitershausen [:philikon] from comment #2)
> Comment on attachment 635222 [details] [diff] [review]
> Sync nsIRadioInterfaceLayer.DATACALL_STATE_*  with ril_consts.js
> 

Philipp correct me if I'm wrong but we should have (also) marked the interface for iid rev given the _UNKNOWN integer value change.
Sorry philikon, last patch was backed out because of b2g bustage. I think it's better to remove DATACALL_STATE_* completely so I made this new patch.

try: https://tbpl.mozilla.org/?tree=Try&rev=f288f07c2a25
Attachment #635222 - Attachment is obsolete: true
Attachment #635657 - Flags: review?(philipp)
Ugh, I somehow read the patch as modifying ril_consts.js instead of nsIRadioInterfaceLayer. Must've been distracted, sorry.
Comment on attachment 635657 [details] [diff] [review]
Remove nsIRadioInterfaceLayer.DATACALL_STATE_*

Review of attachment 635657 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, yes, this makes much more sense. Thanks!
Attachment #635657 - Flags: review?(philipp) → review+
patch bitrotted
Attachment #635657 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/14707b4a5677
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.