B2G RIL: nsIRadioInterfaceLayer.DATACALL_STATE_* values is not synced with ril_consts.js
RESOLVED
FIXED
in mozilla16
Status
()
People
(Reporter: kanru, Assigned: kanru)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment, 2 obsolete attachments)
|
2.52 KB,
patch
|
Details | Diff | Splinter Review |
And the GECKO_NETWORK_STATE_* values in ril_consts.js is synced with nsINetworkManager.NETWORK_STATE_* Should we conciliate this to one place?
|
(Assignee) | |
Comment 1•7 years ago
|
||
Created attachment 635222 [details] [diff] [review] Sync nsIRadioInterfaceLayer.DATACALL_STATE_* with ril_consts.js
Assignee: nobody → kchen
Attachment #635222 -
Flags: review?(philipp)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 635222 [details] [diff] [review] Sync nsIRadioInterfaceLayer.DATACALL_STATE_* with ril_consts.js Review of attachment 635222 [details] [diff] [review]: ----------------------------------------------------------------- Nice catch!
Attachment #635222 -
Flags: review?(philipp) → review+
|
|
(Assignee) | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/edbb25e71396
Target Milestone: --- → mozilla16
|
||
Comment 4•7 years ago
|
||
(In reply to Philipp von Weitershausen [:philikon] from comment #2) > Comment on attachment 635222 [details] [diff] [review] > Sync nsIRadioInterfaceLayer.DATACALL_STATE_* with ril_consts.js > Philipp correct me if I'm wrong but we should have (also) marked the interface for iid rev given the _UNKNOWN integer value change.
|
|
(Assignee) | |
Comment 5•7 years ago
|
||
Backout https://hg.mozilla.org/integration/mozilla-inbound/rev/dced59dc1100
|
|
(Assignee) | |
Comment 6•7 years ago
|
||
Created attachment 635657 [details] [diff] [review] Remove nsIRadioInterfaceLayer.DATACALL_STATE_* Sorry philikon, last patch was backed out because of b2g bustage. I think it's better to remove DATACALL_STATE_* completely so I made this new patch. try: https://tbpl.mozilla.org/?tree=Try&rev=f288f07c2a25
Attachment #635222 -
Attachment is obsolete: true
Attachment #635657 -
Flags: review?(philipp)
|
|
||
Comment 7•7 years ago
|
||
Ugh, I somehow read the patch as modifying ril_consts.js instead of nsIRadioInterfaceLayer. Must've been distracted, sorry.
|
|
||
Comment 8•7 years ago
|
||
Comment on attachment 635657 [details] [diff] [review] Remove nsIRadioInterfaceLayer.DATACALL_STATE_* Review of attachment 635657 [details] [diff] [review]: ----------------------------------------------------------------- Yes, yes, this makes much more sense. Thanks!
Attachment #635657 -
Flags: review?(philipp) → review+
|
|
(Assignee) | |
Comment 9•7 years ago
|
||
Created attachment 636610 [details] [diff] [review] Remove nsIRadioInterfaceLayer.DATACALL_STATE_* patch bitrotted
Attachment #635657 -
Attachment is obsolete: true
|
|
(Assignee) | |
Comment 10•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/14707b4a5677
|
||
Comment 11•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/14707b4a5677
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•