766891 - B2G RIL: nsIRadioInterfaceLayer.DATACALL_STATE_* values is not synced with ril_consts.js

Status: RESOLVED FIXED

Description

[Kan-Ru Chen [:kanru] (UTC+8)]

And the GECKO_NETWORK_STATE_* values in ril_consts.js is synced with nsINetworkManager.NETWORK_STATE_*

Should we conciliate this to one place?

Comment 1

[Kan-Ru Chen [:kanru] (UTC+8)]

Created attachment 635222 [details] [diff] [review]
Sync nsIRadioInterfaceLayer.DATACALL_STATE_*  with ril_consts.js

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 635222 [details] [diff] [review]
Sync nsIRadioInterfaceLayer.DATACALL_STATE_*  with ril_consts.js

Review of attachment 635222 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!

Comment 3

[Kan-Ru Chen [:kanru] (UTC+8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/edbb25e71396

Comment 4

[Justin Wood (:Callek)]

(In reply to Philipp von Weitershausen [:philikon] from comment #2)
> Comment on attachment 635222 [details] [diff] [review]
> Sync nsIRadioInterfaceLayer.DATACALL_STATE_*  with ril_consts.js
> 

Philipp correct me if I'm wrong but we should have (also) marked the interface for iid rev given the _UNKNOWN integer value change.

Comment 5

[Kan-Ru Chen [:kanru] (UTC+8)]

Backout

https://hg.mozilla.org/integration/mozilla-inbound/rev/dced59dc1100

Comment 6

[Kan-Ru Chen [:kanru] (UTC+8)]

Created attachment 635657 [details] [diff] [review]
Remove nsIRadioInterfaceLayer.DATACALL_STATE_*

Sorry philikon, last patch was backed out because of b2g bustage. I think it's better to remove DATACALL_STATE_* completely so I made this new patch.

try: https://tbpl.mozilla.org/?tree=Try&rev=f288f07c2a25

Comment 7

[Philipp von Weitershausen [:philikon]]

Ugh, I somehow read the patch as modifying ril_consts.js instead of nsIRadioInterfaceLayer. Must've been distracted, sorry.

Comment 8

[Philipp von Weitershausen [:philikon]]

Comment on attachment 635657 [details] [diff] [review]
Remove nsIRadioInterfaceLayer.DATACALL_STATE_*

Review of attachment 635657 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, yes, this makes much more sense. Thanks!

Comment 9

[Kan-Ru Chen [:kanru] (UTC+8)]

Created attachment 636610 [details] [diff] [review]
Remove nsIRadioInterfaceLayer.DATACALL_STATE_*

patch bitrotted

Comment 10

[Kan-Ru Chen [:kanru] (UTC+8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/14707b4a5677

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/14707b4a5677