Closed
Bug 766891
Opened 13 years ago
Closed 13 years ago
B2G RIL: nsIRadioInterfaceLayer.DATACALL_STATE_* values is not synced with ril_consts.js
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: kanru, Assigned: kanru)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.52 KB,
patch
|
Details | Diff | Splinter Review |
And the GECKO_NETWORK_STATE_* values in ril_consts.js is synced with nsINetworkManager.NETWORK_STATE_*
Should we conciliate this to one place?
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → kchen
Attachment #635222 -
Flags: review?(philipp)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 635222 [details] [diff] [review]
Sync nsIRadioInterfaceLayer.DATACALL_STATE_* with ril_consts.js
Review of attachment 635222 [details] [diff] [review]:
-----------------------------------------------------------------
Nice catch!
Attachment #635222 -
Flags: review?(philipp) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Target Milestone: --- → mozilla16
|
||
Comment 4•13 years ago
|
||
(In reply to Philipp von Weitershausen [:philikon] from comment #2)
> Comment on attachment 635222 [details] [diff] [review]
> Sync nsIRadioInterfaceLayer.DATACALL_STATE_* with ril_consts.js
>
Philipp correct me if I'm wrong but we should have (also) marked the interface for iid rev given the _UNKNOWN integer value change.
|
|
Assignee | |
Comment 5•13 years ago
|
||
|
|
Assignee | |
Comment 6•13 years ago
|
||
Sorry philikon, last patch was backed out because of b2g bustage. I think it's better to remove DATACALL_STATE_* completely so I made this new patch.
try: https://tbpl.mozilla.org/?tree=Try&rev=f288f07c2a25
Attachment #635222 -
Attachment is obsolete: true
Attachment #635657 -
Flags: review?(philipp)
|
|
||
Comment 7•13 years ago
|
||
Ugh, I somehow read the patch as modifying ril_consts.js instead of nsIRadioInterfaceLayer. Must've been distracted, sorry.
|
|
||
Comment 8•13 years ago
|
||
Comment on attachment 635657 [details] [diff] [review]
Remove nsIRadioInterfaceLayer.DATACALL_STATE_*
Review of attachment 635657 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, yes, this makes much more sense. Thanks!
Attachment #635657 -
Flags: review?(philipp) → review+
|
|
Assignee | |
Comment 10•13 years ago
|
||
|
||
Comment 11•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•