The default bug view has changed. See this FAQ.

B2G RIL: nsIRadioInterfaceLayer.DATACALL_STATE_* values is not synced with ril_consts.js

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kanru, Assigned: kanru)

Tracking

Trunk
mozilla16
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
And the GECKO_NETWORK_STATE_* values in ril_consts.js is synced with nsINetworkManager.NETWORK_STATE_*

Should we conciliate this to one place?
(Assignee)

Comment 1

5 years ago
Created attachment 635222 [details] [diff] [review]
Sync nsIRadioInterfaceLayer.DATACALL_STATE_*  with ril_consts.js
Assignee: nobody → kchen
Attachment #635222 - Flags: review?(philipp)
Comment on attachment 635222 [details] [diff] [review]
Sync nsIRadioInterfaceLayer.DATACALL_STATE_*  with ril_consts.js

Review of attachment 635222 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!
Attachment #635222 - Flags: review?(philipp) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/edbb25e71396
Target Milestone: --- → mozilla16
(In reply to Philipp von Weitershausen [:philikon] from comment #2)
> Comment on attachment 635222 [details] [diff] [review]
> Sync nsIRadioInterfaceLayer.DATACALL_STATE_*  with ril_consts.js
> 

Philipp correct me if I'm wrong but we should have (also) marked the interface for iid rev given the _UNKNOWN integer value change.
(Assignee)

Comment 5

5 years ago
Backout

https://hg.mozilla.org/integration/mozilla-inbound/rev/dced59dc1100
(Assignee)

Comment 6

5 years ago
Created attachment 635657 [details] [diff] [review]
Remove nsIRadioInterfaceLayer.DATACALL_STATE_*

Sorry philikon, last patch was backed out because of b2g bustage. I think it's better to remove DATACALL_STATE_* completely so I made this new patch.

try: https://tbpl.mozilla.org/?tree=Try&rev=f288f07c2a25
Attachment #635222 - Attachment is obsolete: true
Attachment #635657 - Flags: review?(philipp)
Ugh, I somehow read the patch as modifying ril_consts.js instead of nsIRadioInterfaceLayer. Must've been distracted, sorry.
Comment on attachment 635657 [details] [diff] [review]
Remove nsIRadioInterfaceLayer.DATACALL_STATE_*

Review of attachment 635657 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, yes, this makes much more sense. Thanks!
Attachment #635657 - Flags: review?(philipp) → review+
(Assignee)

Comment 9

5 years ago
Created attachment 636610 [details] [diff] [review]
Remove nsIRadioInterfaceLayer.DATACALL_STATE_*

patch bitrotted
Attachment #635657 - Attachment is obsolete: true
(Assignee)

Comment 10

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/14707b4a5677
https://hg.mozilla.org/mozilla-central/rev/14707b4a5677
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.