The default bug view has changed. See this FAQ.

Correct remaining nsIScreen_MOZILLA_2_0_BRANCH comment in nsBaseScreen.h

RESOLVED FIXED in mozilla16

Status

()

Core
Widget
--
minor
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: emorley, Assigned: Bill Hamilton, Mentored)

Tracking

Trunk
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 672166 merged nsIScreen_MOZILLA_2_0_BRANCH into nsIScreen, however left one comment behind:
http://mxr.mozilla.org/mozilla-central/search?string=nsIScreen_MOZILLA_2_0_BRANCH

We need to s/nsIScreen_MOZILLA_2_0_BRANCH/nsIScreen/ in:
http://mxr.mozilla.org/mozilla-central/source/widget/xpwidgets/nsBaseScreen.h#51
(Assignee)

Comment 1

5 years ago
OK to take this as a first bug?
(Assignee)

Comment 2

5 years ago
Created attachment 636059 [details] [diff] [review]
Patch to adjust the comment

Does this look ok, or have I misunderstood what is asked for?
Attachment #636059 - Flags: review?(bmo)
Attachment #636059 - Flags: feedback?(bmo)
(Reporter)

Updated

5 years ago
Assignee: nobody → william
(Reporter)

Comment 3

5 years ago
Comment on attachment 636059 [details] [diff] [review]
Patch to adjust the comment

Hi Bill - sorry for the delay - I was away over the weekend.

It's perfectly fine for you to take this as a first bug - the patch looks good and is in the correct format + with commit message, which is awesome :-)

I'm not a peer of the widget module so I'll request review from someone who is (https://wiki.mozilla.org/Modules/Core#Widget).

Thanks for the patch! :-)
Attachment #636059 - Flags: review?(roc)
Attachment #636059 - Flags: review?(bmo)
Attachment #636059 - Flags: feedback?(bmo)
Attachment #636059 - Flags: feedback+
Attachment #636059 - Flags: review?(roc) → review+
(Reporter)

Comment 4

5 years ago
I've just landed this patch on mozilla-inbound for you:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c562af29a9db

mozilla-inbound gets merged to mozilla-central roughly once a day - at which point the bug will be marked fixed.

Thank you for the patch - hopefully it's given you a rough idea of the bug workflow. Looking forward to your next one - if you need any ideas for things to work on - please ask on IRC on #developers https://wiki.mozilla.org/IRC :-)
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla16
(Reporter)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c562af29a9db
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

3 years ago
Mentor: emorley@mozilla.com
Whiteboard: [mentor=edmorley]
You need to log in before you can comment on or make changes to this bug.