Closed Bug 766985 Opened 11 years ago Closed 11 years ago

Don't show the warning triangle icon for sites with mixed content

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox14 --- fixed
firefox15 --- fixed
firefox16 --- fixed

People

(Reporter: shorlander, Assigned: shorlander)

References

Details

Attachments

(3 files)

Remove Mixed State Icon - Beta
8.37 KB, patch
dao
: review+
lsblakk
: approval-mozilla-beta+
Details | Diff | Splinter Review
Remove Mixed State Icon - Aurora
8.48 KB, patch
dao
: review+
Gavin
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Remove Mixed State Icon - Nightly
7.78 KB, patch
dao
: review+
Details | Diff | Splinter Review 
The warning icon is too alarming and frequent, turning up on any https site that displays http images.

Until we can differentiate between different kinds of mixed content we should just show the default globe instead of the lock.
Agreed - let's get to the right UI in the next version rather than doing this now.
Component: Location Bar → Theme
QA Contact: location.bar → theme
[Approval Request Comment]
Bug caused by bug 747090 and bug 755429
User impact if declined: Warning icon desensitization, unnecessary anxiety and confusion about meaning
Risk to taking this patch: Low risk CSS removal and image deletion
String or UUID changes made by this patch: None
Attachment #635866 - Flags: review?(jaws)
Attachment #635866 - Flags: approval-mozilla-beta?

        Attachment #635867 -
        Flags: review?(jaws)

    
  

        Attachment #635869 -
        Flags: review?(jaws) → review+

    
  

        Attachment #635867 -
        Flags: review?(jaws) → review+

    
  

        Attachment #635866 -
        Flags: review?(jaws) → review+

    
  
Blocks: 747090

    
    

    
  
Comment on attachment 635867 [details] [diff] [review]
Remove Mixed State Icon - Aurora

[Approval Request Comment]
Bug caused by bug 747090 and bug 755429
User impact if declined: Warning icon desensitization, unnecessary anxiety and confusion about meaning
Risk to taking this patch: Low risk CSS removal and image deletion
String or UUID changes made by this patch: None

        Attachment #635867 -
        Flags: approval-mozilla-aurora?

        Attachment #635867 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Comment on attachment 635866 [details] [diff] [review]
Remove Mixed State Icon - Beta

*stamp*

        Attachment #635866 -
        Flags: approval-mozilla-beta? → approval-mozilla-beta+

    
  
Keywords: checkin-needed

    
    

    
  
Pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0880a8ce3407

          status-firefox16:
          --- → fixed
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: Firefox 14 → Firefox 16
Version: Trunk → 14 Branch

    
    

    
  
Pushed to mozilla-beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/3b1c3202112f
Assignee: nobody → shorlander
Status: NEW → ASSIGNED

          status-firefox14:
          --- → fixed

          status-firefox15:
          --- → affected

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0880a8ce3407
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 16 → ---
Version: 14 Branch → Trunk

    
  
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16

          You need to log in
          before you can comment on or make changes to this bug.