766988 - Disabling screenshot code still allows incremental screenshot updates

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Currently if you change sDisableScreenshot to true and start Fennec, you get the following exception:

06-21 15:15:34.866 W/System.err( 4982): java.lang.NullPointerException
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.ScreenshotHandler$RepaintRunnable.addRectToRepaint(GeckoAppShell.java:2263)
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.ScreenshotHandler.notifyPaintedRect(GeckoAppShell.java:2276)
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.GeckoAppShell.notifyPaintedRect(GeckoAppShell.java:2192)
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
06-21 15:15:34.874 W/System.err( 4982):     at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:476)
06-21 15:15:34.874 W/System.err( 4982):     at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:90)

because sCheckerboardPageRect is set to null, but the paint listener is still running and tries to queue up dirty rects. This codepath should also check for sDisableScreenshot.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch (v2)

Updated patch to also take care of bug 766498 since it's pretty much the same code.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c2bab7807b3

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7c2bab7807b3