Disabling screenshot code still allows incremental screenshot updates

RESOLVED FIXED in Firefox 16

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

Trunk
Firefox 16
All
Android
Points:
---

Firefox Tracking Flags

(firefox16 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Currently if you change sDisableScreenshot to true and start Fennec, you get the following exception:

06-21 15:15:34.866 W/System.err( 4982): java.lang.NullPointerException
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.ScreenshotHandler$RepaintRunnable.addRectToRepaint(GeckoAppShell.java:2263)
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.ScreenshotHandler.notifyPaintedRect(GeckoAppShell.java:2276)
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.GeckoAppShell.notifyPaintedRect(GeckoAppShell.java:2192)
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
06-21 15:15:34.866 W/System.err( 4982):     at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
06-21 15:15:34.874 W/System.err( 4982):     at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:476)
06-21 15:15:34.874 W/System.err( 4982):     at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:90)

because sCheckerboardPageRect is set to null, but the paint listener is still running and tries to queue up dirty rects. This codepath should also check for sDisableScreenshot.
Created attachment 635323 [details] [diff] [review]
Patch
Attachment #635323 - Flags: review?(blassey.bugs)
Created attachment 635328 [details] [diff] [review]
Patch (v2)

Updated patch to also take care of bug 766498 since it's pretty much the same code.
Attachment #635323 - Attachment is obsolete: true
Attachment #635323 - Flags: review?(blassey.bugs)
Attachment #635328 - Flags: review?(blassey.bugs)
Duplicate of this bug: 766498
Attachment #635328 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c2bab7807b3
status-firefox16: --- → fixed
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/7c2bab7807b3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.