In the developer toolbar, the debugger should be named "debugger", not "Script"

RESOLVED FIXED in Firefox 16

Status

()

Product:
Firefox
Component:
Developer Tools: Debugger
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: paul, Assigned: paul)

Tracking

Version:
Trunk
Target:
Firefox 16
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 2 obsolete attachments)

[in-fx-team] v1.1
2.33 KB, patch
dao
: review+
rc
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
5 years ago 
to be consistent with the appmenu and the menubar.
(Assignee)

Comment 1

•
5 years ago 
Created attachment 635335 [details] [diff] [review]
v1
(Assignee)

Comment 2

•
5 years ago 
Created attachment 635337 [details] [diff] [review]
v1
 (Assignee)

Updated

•
5 years ago
Attachment #635335 - Attachment is obsolete: true
 (Assignee)

Updated

•
5 years ago
Attachment #635337 - Flags: review?(past)

Comment 3

•
5 years ago 
Comment on attachment 635337 [details] [diff] [review]
v1

Review of attachment 635337 [details] [diff] [review]:
-----------------------------------------------------------------

OK by me, but you probably want to get a browser peer to look at it, too.
Attachment #635337 - Flags: review?(past) → review+
 (Assignee)

Updated

•
5 years ago
Attachment #635337 - Flags: review?(dao)

Comment 4

•
5 years ago 
Comment on attachment 635337 [details] [diff] [review]
v1

This makes scriptsButton.label unused, i.e. you should remove it.

(aside: debuggerMenu.label2 should have been debuggerMenu2.label...)
Attachment #635337 - Flags: review?(dao) → review-
 (Assignee)

Comment 5

•
5 years ago 
Created attachment 636258 [details] [diff] [review]
[in-fx-team] v1.1
 (Assignee)

Updated

•
5 years ago
Attachment #635337 - Attachment is obsolete: true
 (Assignee)

Updated

•
5 years ago
Attachment #636258 - Flags: review?(dao)

Updated

•
5 years ago
Attachment #636258 - Flags: review?(dao) → review+
 (Assignee)

Updated

•
5 years ago
Whiteboard: [land-in-fx-team]
 (Assignee)

Updated

•
5 years ago
Attachment #636258 - Flags: review?(rcampbell)
 (Assignee)

Updated

•
5 years ago
Whiteboard: [land-in-fx-team]

Comment 6

•
5 years ago 
Comment on attachment 636258 [details] [diff] [review]
[in-fx-team] v1.1

yes, but sadly, not for aurora.
Attachment #636258 - Flags: review?(rcampbell) → review+
 (Assignee)

Updated

•
5 years ago
Whiteboard: [land-in-fx-team]

Comment 7

•
5 years ago 
Comment on attachment 636258 [details] [diff] [review]
[in-fx-team] v1.1

https://hg.mozilla.org/integration/fx-team/rev/b8956522f66c
Attachment #636258 - Attachment description: v1.1 → [in-fx-team] v1.1

Updated

•
5 years ago
Assignee: nobody → paul
Status: NEW → ASSIGNED
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]

Comment 8

•
5 years ago 
https://hg.mozilla.org/mozilla-central/rev/b8956522f66c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
You need to log in before you can comment on or make changes to this bug.