Closed Bug 766999 Opened 10 years ago Closed 10 years ago

In the developer toolbar, the debugger should be named "debugger", not "Script"

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 16

People

(Reporter: paul, Assigned: paul)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 2 obsolete files)

[in-fx-team] v1.1
2.33 KB, patch
dao
: review+
rcampbell
: review+
Details | Diff | Splinter Review 
to be consistent with the appmenu and the menubar.
Attached patch v1 (obsolete) — — Splinter Review
Attached patch v1 (obsolete) — — Splinter Review
Attachment #635335 - Attachment is obsolete: true
Attachment #635337 - Flags: review?(past)
Comment on attachment 635337 [details] [diff] [review]
v1

Review of attachment 635337 [details] [diff] [review]:
-----------------------------------------------------------------

OK by me, but you probably want to get a browser peer to look at it, too.
Attachment #635337 - Flags: review?(past) → review+
Attachment #635337 - Flags: review?(dao)
Comment on attachment 635337 [details] [diff] [review]
v1

This makes scriptsButton.label unused, i.e. you should remove it.

(aside: debuggerMenu.label2 should have been debuggerMenu2.label...)
Attachment #635337 - Flags: review?(dao) → review-
Attachment #635337 - Attachment is obsolete: true
Attachment #636258 - Flags: review?(dao)
Attachment #636258 - Flags: review?(dao) → review+
Whiteboard: [land-in-fx-team]
Attachment #636258 - Flags: review?(rcampbell)
Whiteboard: [land-in-fx-team]
Comment on attachment 636258 [details] [diff] [review]
[in-fx-team] v1.1

yes, but sadly, not for aurora.
Attachment #636258 - Flags: review?(rcampbell) → review+
Whiteboard: [land-in-fx-team]
Comment on attachment 636258 [details] [diff] [review]
[in-fx-team] v1.1

https://hg.mozilla.org/integration/fx-team/rev/b8956522f66c
Attachment #636258 - Attachment description: v1.1 → [in-fx-team] v1.1
Assignee: nobody → paul
Status: NEW → ASSIGNED
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b8956522f66c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.