767024 - Building android on OS X fails due to missing readelf

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Trying to build android results in the following failure:

Traceback (most recent call last):
  File "/Users/kats/zspace/mozilla-git/xpcom/stub/dependentlibs.py", line 102, in <module>
    main()
  File "/Users/kats/zspace/mozilla-git/xpcom/stub/dependentlibs.py", line 99, in main
    print '\n'.join(dependentlibs(lib, options.libpaths, func))
  File "/Users/kats/zspace/mozilla-git/xpcom/stub/dependentlibs.py", line 72, in dependentlibs
    for dep in func(lib):
  File "/Users/kats/zspace/mozilla-git/xpcom/stub/dependentlibs.py", line 29, in dependentlibs_readelf
    proc = subprocess.Popen(['readelf', '-d', lib], stdout = subprocess.PIPE)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 679, in __init__
    errread, errwrite)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1228, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
make[5]: *** [../../dist/bin/dependentlibs.list] Error 1
make[5]: *** Deleting file `../../dist/bin/dependentlibs.list'
make[4]: *** [libs_tier_platform] Error 2
make[3]: *** [tier_platform] Error 2
make[2]: *** [default] Error 2
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2


I don't have readelf on my $PATH, which this seems to rely on.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Allow dependentlibs.py to work when cross-compiling for Android on OSX

Comment 2

[Kartikaya Gupta (email:[e-mail])]

This patch works for me. Thanks!

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 635414 [details] [diff] [review]
Allow dependentlibs.py to work when cross-compiling for Android on OSX

Review of attachment 635414 [details] [diff] [review]:
-----------------------------------------------------------------

Should you change js/src/config/autoconf.mk.in too?

Comment 4

[Mike Hommey [:glandium]]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #3)
> Comment on attachment 635414 [details] [diff] [review]
> Allow dependentlibs.py to work when cross-compiling for Android on OSX
> 
> Review of attachment 635414 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Should you change js/src/config/autoconf.mk.in too?

It's not used in js/src.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03f1fdde2137

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/03f1fdde2137