remove synchronous DNS resolution in nsSOCKSIOLayer.cpp

RESOLVED FIXED in mozilla16

Status

()

Core
Networking: DNS
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Josh Aas, Assigned: mcmanus)

Tracking

(Blocks: 1 bug)

Trunk
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Snappy:P1])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
netwerk/socket/nsSOCKSIOLayer.cpp:
219 PRStatus
220 nsSOCKSSocketInfo::ConnectToProxy(PRFileDesc *fd)
[...]
234         rv = dns->Resolve(mProxyHost, 0, getter_AddRefs(mDnsRec));

We probably shouldn't ever make synchronous DNS resolution calls, and we definitely shouldn't do it on the main thread. Removing this stuff is a high priority.
Created attachment 636862 [details] [diff] [review]
patch 0

while I do some more testing lets call this WIP
Comment on attachment 636862 [details] [diff] [review]
patch 0

confirmed behavior before/after patch matches for:

* normal dns based proxy
* ip based proxy
* dns resolution that takes a long time
* invalid host name
* valid hostname, but invalid proxy

Christian, do you have time to look at this?
Attachment #636862 - Flags: review?(cbiesinger)
Comment on attachment 636862 [details] [diff] [review]
patch 0

nice :)
Attachment #636862 - Flags: review?(cbiesinger) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/116dcbbd39ba
Target Milestone: --- → mozilla16

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/116dcbbd39ba
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 804237

Updated

5 years ago
Depends on: 828761
No longer depends on: 828761
You need to log in before you can comment on or make changes to this bug.