767159 - remove synchronous DNS resolution in nsSOCKSIOLayer.cpp

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect)

Description

[Josh Aas]

netwerk/socket/nsSOCKSIOLayer.cpp:
219 PRStatus
220 nsSOCKSSocketInfo::ConnectToProxy(PRFileDesc *fd)
[...]
234         rv = dns->Resolve(mProxyHost, 0, getter_AddRefs(mDnsRec));

We probably shouldn't ever make synchronous DNS resolution calls, and we definitely shouldn't do it on the main thread. Removing this stuff is a high priority.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch 0

while I do some more testing lets call this WIP

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 636862 [details] [diff] [review]
patch 0

confirmed behavior before/after patch matches for:

* normal dns based proxy
* ip based proxy
* dns resolution that takes a long time
* invalid host name
* valid hostname, but invalid proxy

Christian, do you have time to look at this?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 636862 [details] [diff] [review]
patch 0

nice :)

Comment 4

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/116dcbbd39ba

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/116dcbbd39ba