IonMonkey: name cache attempts to use an uninitialized label

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mjrosenb, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 635540 [details] [diff] [review]
/home/mrosenberg/patches/fixNameCache-r0.patch

When the name lookup is infallible, we still attempt to patch it, which on arm will throw many assertions, and on x86/x64 stops over the 4 bytes preceding the function (from what I can tell)
Attachment #635540 - Flags: review?(dvander)
Comment on attachment 635540 [details] [diff] [review]
/home/mrosenberg/patches/fixNameCache-r0.patch

Review of attachment 635540 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.
Attachment #635540 - Flags: review?(dvander) → review+
(Reporter)

Comment 2

5 years ago
landed: http://hg.mozilla.org/projects/ionmonkey/rev/2bf3f40dc21a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.