As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 767218 - IonMonkey: name cache attempts to use an uninitialized label
: IonMonkey: name cache attempts to use an uninitialized label
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All Linux
: -- normal (vote)
: ---
Assigned To: general
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2012-06-21 17:39 PDT by Marty Rosenberg [:mjrosenb]
Modified: 2012-06-21 19:53 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

/home/mrosenberg/patches/fixNameCache-r0.patch (1.84 KB, patch)
2012-06-21 17:39 PDT, Marty Rosenberg [:mjrosenb]
dvander: review+
Details | Diff | Splinter Review

Description User image Marty Rosenberg [:mjrosenb] 2012-06-21 17:39:52 PDT
Created attachment 635540 [details] [diff] [review]

When the name lookup is infallible, we still attempt to patch it, which on arm will throw many assertions, and on x86/x64 stops over the 4 bytes preceding the function (from what I can tell)
Comment 1 User image David Anderson [:dvander] 2012-06-21 17:42:08 PDT
Comment on attachment 635540 [details] [diff] [review]

Review of attachment 635540 [details] [diff] [review]:

Good catch.
Comment 2 User image Marty Rosenberg [:mjrosenb] 2012-06-21 19:53:28 PDT

Note You need to log in before you can comment on or make changes to this bug.