Last Comment Bug 767248 - IonMonkey: (ARM) visitAbsI relies on neg32 setting condition codes
: IonMonkey: (ARM) visitAbsI relies on neg32 setting condition codes
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: ARM Linux
: -- normal (vote)
: ---
Assigned To: general
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-21 19:50 PDT by Marty Rosenberg [:mjrosenb]
Modified: 2012-07-27 16:28 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
/home/mrosenberg/patches/setCodsInNeg32-r0.patch (814 bytes, patch)
2012-06-21 19:50 PDT, Marty Rosenberg [:mjrosenb]
Jacob.Bramley: review+
Details | Diff | Splinter Review

Description Marty Rosenberg [:mjrosenb] 2012-06-21 19:50:15 PDT
Created attachment 635587 [details] [diff] [review]
/home/mrosenberg/patches/setCodsInNeg32-r0.patch

not entirely sure what the convention is, but it seems like this code is relying on neg32() setting condition codes, so I say let's go with it.
Comment 1 Marty Rosenberg [:mjrosenb] 2012-07-27 16:28:50 PDT
landed: http://hg.mozilla.org/projects/ionmonkey/rev/753ff9eb4b72

Note You need to log in before you can comment on or make changes to this bug.