The filtering textbox expands when entering a string

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Developer Tools: Debugger
P3
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ioana (away), Assigned: vporof)

Tracking

15 Branch
Firefox 16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120621 Firefox/15.0a2 (20120621042006)

STR:
1. Load http://htmlpad.org/debugger/ in the browser.
2. Open the Debugger (Tools->Web developer->Debugger, or press Ctrl+Shift+S).
3. Select the jquery.min.js script in the dropdown.
4. Enter a "j" in the filtering textbox.

The textbox expands automatically. It's a small expansion but it's very visible to me.
(Reporter)

Comment 1

5 years ago
Created attachment 635746 [details]
Dropdown content with no filters
(Reporter)

Comment 2

5 years ago
Created attachment 635748 [details]
Filter textbox expanding
(Assignee)

Comment 3

5 years ago
Can't reproduce this on OS X, but I think we can get away with this if we set a specific width in the CSS.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Priority: -- → P3
(Assignee)

Comment 4

5 years ago
Created attachment 638778 [details] [diff] [review]
v1
Attachment #638778 - Flags: review?(past)
Why does this patch affect all platforms? This bug is likely due to <http://hg.mozilla.org/mozilla-central/annotate/f38d6df93cad/toolkit/themes/winstripe/global/textbox-aero.css#l7> and therefore Windows-specific.
(Assignee)

Comment 6

5 years ago
(In reply to Dão Gottwald [:dao] from comment #5)
> Why does this patch affect all platforms? This bug is likely due to
> <http://hg.mozilla.org/mozilla-central/annotate/f38d6df93cad/toolkit/themes/
> winstripe/global/textbox-aero.css#l7> and therefore Windows-specific.

If we're going to add a width, we might as well do it on all platforms.
Is there something inherently wrong with doing so? I have no objections on fixing this only on Windows, but it would be nice to have the same sizes apply on all OS.
<http://hg.mozilla.org/mozilla-central/annotate/f38d6df93cad/toolkit/themes/winstripe/global/textbox-aero.css#l7> affecting the textbox width is basically a toolkit bug that would ideally be fixed at a lower level rather than on a per-textbox basis. So unless the width is useful for other reasons, I think it makes sense to think of this as an interim solution that can be limited to Windows.
(In reply to Dão Gottwald [:dao] from comment #7)
> <http://hg.mozilla.org/mozilla-central/annotate/f38d6df93cad/toolkit/themes/
> winstripe/global/textbox-aero.css#l7> affecting the textbox width is
> basically a toolkit bug that would ideally be fixed at a lower level rather
> than on a per-textbox basis. So unless the width is useful for other
> reasons, I think it makes sense to think of this as an interim solution that
> can be limited to Windows.

In that same line of thought it may be best to add an aero-only debugger stylesheet with this workaround. On the other hand this may be going too far.

I'm personally fine either way.
(Assignee)

Comment 9

5 years ago
(In reply to Panos Astithas [:past] from comment #8)
> (In reply to Dão Gottwald [:dao] from comment #7)
> > <http://hg.mozilla.org/mozilla-central/annotate/f38d6df93cad/toolkit/themes/
> > winstripe/global/textbox-aero.css#l7> affecting the textbox width is
> > basically a toolkit bug that would ideally be fixed at a lower level rather
> > than on a per-textbox basis. So unless the width is useful for other
> > reasons, I think it makes sense to think of this as an interim solution that
> > can be limited to Windows.
> 
> In that same line of thought it may be best to add an aero-only debugger
> stylesheet with this workaround. On the other hand this may be going too far.
> 
> I'm personally fine either way.

Let's just add the width in the debugger win css as a temporary fix.
Or we could just not do anything and let the toolkit people to fix it? Who should we ping?
(Assignee)

Comment 10

5 years ago
Created attachment 642345 [details] [diff] [review]
v2

Alright then.
Attachment #642345 - Flags: review?(past)
Attachment #638778 - Attachment is obsolete: true
Attachment #638778 - Flags: review?(past)
Comment on attachment 642345 [details] [diff] [review]
v2

Review of attachment 642345 [details] [diff] [review]:
-----------------------------------------------------------------

A comment that points to the bug and/or textbox-aero.css would help us remember when to get rid of it.
Attachment #642345 - Flags: review?(past) → review+
(Assignee)

Comment 12

5 years ago
Created attachment 642360 [details] [diff] [review]
v2.1

Commented.
(Assignee)

Updated

5 years ago
Whiteboard: [land-in-fx-team]
Attachment #642345 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/492fb99ae0d8
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/492fb99ae0d8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
You need to log in before you can comment on or make changes to this bug.