767388 - Kill NS_DEBUG

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Watt [:jwatt]]

The ifdefs for mDrawEventTargetFrame and mPresArenaAllocCount in nsIPresShell are not consistent. They should be.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Actually, this patch isn't right. The issue here is that mPresArenaAllocCount is defined inside NS_DEBUG, but used inside DEBUG. I don't know which one is right, but I'll update the patch if you tell me bz. :)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Just use DEBUG.

Comment 4

[Jonathan Watt [:jwatt]]

Seems like NS_DEBUG is just an alias for DEBUG at this point. I think I'll just use Eclipse's refactoring tools to kill it, unless you tell me it still has a purpose.

Comment 5

[Boris Zbarsky [:bzbarsky]]

That sounds great!

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: patch to kill NS_DEBUG

I went through and checked it manually, but feel free to do the same. The only line that isn't a straight s/NS_DEBUG/DEBUG/ is the one in nsDebug.h to remove the define.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 635948 [details] [diff] [review]
patch to kill NS_DEBUG

r=me

Comment 8

[Jonathan Watt [:jwatt]]

Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/db9fc4c50e24

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/db9fc4c50e24