Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
The ifdefs for mDrawEventTargetFrame and mPresArenaAllocCount in nsIPresShell are not consistent. They should be.
(Assignee)

Comment 1

5 years ago
Created attachment 635757 [details] [diff] [review]
patch
Attachment #635757 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

5 years ago
Actually, this patch isn't right. The issue here is that mPresArenaAllocCount is defined inside NS_DEBUG, but used inside DEBUG. I don't know which one is right, but I'll update the patch if you tell me bz. :)
(Assignee)

Updated

5 years ago
Summary: Make the ifdefs for mDrawEventTargetFrame and mPresArenaAllocCount consistent → Make the ifdefs for mPresArenaAllocCount consistent
Just use DEBUG.
(Assignee)

Comment 4

5 years ago
Seems like NS_DEBUG is just an alias for DEBUG at this point. I think I'll just use Eclipse's refactoring tools to kill it, unless you tell me it still has a purpose.
That sounds great!
(Assignee)

Updated

5 years ago
Summary: Make the ifdefs for mPresArenaAllocCount consistent → Kill NS_DEBUG
(Assignee)

Comment 6

5 years ago
Created attachment 635948 [details] [diff] [review]
patch to kill NS_DEBUG

I went through and checked it manually, but feel free to do the same. The only line that isn't a straight s/NS_DEBUG/DEBUG/ is the one in nsDebug.h to remove the define.
Attachment #635757 - Attachment is obsolete: true
Attachment #635757 - Flags: review?(bzbarsky)
Attachment #635948 - Flags: review?(bzbarsky)
Comment on attachment 635948 [details] [diff] [review]
patch to kill NS_DEBUG

r=me
Attachment #635948 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 8

5 years ago
Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/db9fc4c50e24
Target Milestone: --- → mozilla16

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/db9fc4c50e24
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.